relax rules for inaccessible

the-guild-org · Jan 26, 2024 · 3d6ca58 · 3d6ca58
1 parent 98b90c9
commit 3d6ca58
Show file tree

Hide file tree

Showing 4 changed files with 58 additions and 6 deletions.
diff --git a/.changeset/bright-pants-accept.md b/.changeset/bright-pants-accept.md
@@ -0,0 +1,5 @@
+---
+'@theguild/federation-composition': patch
+---
+
+Fix REQUIRED_INACCESSIBLE occurring on inaccessible fields/input types
diff --git a/__tests__/supergraph/errors/REQUIRED_INACCESSIBLE.spec.ts b/__tests__/supergraph/errors/REQUIRED_INACCESSIBLE.spec.ts
@@ -13,7 +13,6 @@ testVersions((api, version) => {
                 url: "https://specs.apollo.dev/federation/${version}"
                 import: ["@key", "@inaccessible"]
               )
-
             type Query {
               a(id: ID! @inaccessible): Int!
             }
@@ -33,7 +32,6 @@ testVersions((api, version) => {
         ]),
       }),
     );
-
     expect(
       api.composeServices([
         {
@@ -44,12 +42,11 @@ testVersions((api, version) => {
                 url: "https://specs.apollo.dev/federation/${version}"
                 import: ["@key", "@inaccessible"]
               )
-
+              
             input A {
               id: ID! @inaccessible
               b: Int
             }
-
             type Query {
               a(a: A): Int!
             }
@@ -69,5 +66,49 @@ testVersions((api, version) => {
         ]),
       }),
     );
+
+    expect(
+      api.composeServices([
+        {
+          name: 'users',
+          typeDefs: graphql`
+          extend schema
+            @link(
+              url: "https://specs.apollo.dev/federation/${version}"
+              import: ["@inaccessible"]
+            )
+
+          type Query {
+            a(id: ID! @inaccessible): Int!@inaccessible
+            b: Int!
+          }
+        `,
+        },
+      ])?.errors,
+    ).toBeUndefined();
+
+    expect(
+      api.composeServices([
+        {
+          name: 'users',
+          typeDefs: graphql`
+          extend schema
+            @link(
+              url: "https://specs.apollo.dev/federation/${version}"
+              import: ["@inaccessible"]
+            )
+
+          input A @inaccessible {
+            a: Int! @inaccessible
+          }
+
+          type Query {
+            a(id: A! @inaccessible): Int! @inaccessible
+            b: Int!
+          }
+        `,
+        },
+      ])?.errors,
+    ).toBeUndefined();
   });
 });
diff --git a/src/compose.ts b/src/compose.ts
@@ -107,11 +107,13 @@ ${print({
 export type CompositionResult = CompositionFailure | CompositionSuccess;
 
 export interface CompositionFailure {
+  supergraphSdl?: undefined;
   errors: GraphQLError[];
 }
 
 export interface CompositionSuccess {
   supergraphSdl: string;
+  errors?: undefined;
 }
 
 export function assertCompositionSuccess(

diff --git a/src/supergraph/validation/rules/required-argument-or-field-is-not-inaccessible-rule.ts b/src/supergraph/validation/rules/required-argument-or-field-is-not-inaccessible-rule.ts
@@ -7,7 +7,11 @@ export function RequiredArgumentOrFieldIsNotInaccessibleRule(
 ): SupergraphVisitorMap {
   return {
     InputObjectTypeField(inputObjectState, fieldState) {
-      if (fieldState.type.endsWith('!') && fieldState.inaccessible) {
+      if (
+        !inputObjectState.inaccessible &&
+        fieldState.inaccessible &&
+        fieldState.type.endsWith('!')
+      ) {
         context.reportError(
           new GraphQLError(
             `Input field "${inputObjectState.name}.${fieldState.name}" is @inaccessible but is a required input field of its type.`,
@@ -21,7 +25,7 @@ export function RequiredArgumentOrFieldIsNotInaccessibleRule(
       }
     },
     ObjectTypeFieldArg(objectState, fieldState, argState) {
-      if (argState.type.endsWith('!') && argState.inaccessible) {
+      if (!fieldState.inaccessible && argState.inaccessible && argState.type.endsWith('!')) {
         context.reportError(
           new GraphQLError(
             `Argument "${objectState.name}.${fieldState.name}(${argState.name}:)" is @inaccessible but is a required argument of its field.`,