-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please the Markdown Linter via Cleanup. #44
base: main
Are you sure you want to change the base?
Conversation
e8ac2e1
to
7e5a3c0
Compare
f9089c3
to
1e43478
Compare
@@ -138,7 +138,7 @@ If you need to debug an issue that is occurring through use in matrix, | |||
say the unban command has stopped working, you can launch | |||
mjolnir from the JavaScript Debug Terminal using `yarn test:manual`. | |||
This will launch mjolnir using the config found in `config/harness.yaml`. | |||
You can now open https://app.element.io, change the server to `localhost:8081`, | |||
You can now open [https://app.element.io](https://app.element.io), change the server to `localhost:8081`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can now open [https://app.element.io](https://app.element.io), change the server to `localhost:8081`, | |
You can now open <https://app.element.io>, change the server to `localhost:8081`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick way to trigger a build failure. I did exactly this before and it triggers a build failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<link>
isn't valid commonmark last I checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown linter thought it was fine but Docusaurus wont think that and will trigger a build failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<link>
isn't valid commonmark last I checked.
It's valid commonmark. Search "autolink" in spec. Iirc it's even only part of commonmark and not others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown linter thought it was fine but Docusaurus wont think that and will trigger a build failure.
Smells like they parse mdx rather than commonmark markdown 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, Docusaurus v3 uses the MDX format for all files
This PR pleases the markdown linter via a general cleanup of errors it found. Tho if a error in its regards is invalid as far as im concerned its ignored.