Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --invite to unban command #666

Merged

Conversation

nexy7574
Copy link
Contributor

This PR closes #622 by adding a --invite flag to the unban command.

This still needs a bit of work and does not currently work/pass tests, will complete later.

@Gnuxie Gnuxie force-pushed the nexy7574/enhancement/reinvite-on-ban branch from 8223545 to de2663c Compare January 15, 2025 00:30
src/commands/Unban.ts Outdated Show resolved Hide resolved
src/commands/Unban.ts Show resolved Hide resolved
@Gnuxie Gnuxie force-pushed the nexy7574/enhancement/reinvite-on-ban branch from de2663c to e971c49 Compare January 19, 2025 15:19
@Gnuxie
Copy link
Member

Gnuxie commented Jan 19, 2025

It would be nice if we could rewrite the entire command to preview unbanning, probably by stealing code from the standard capability renderer https://github.com/the-draupnir-project/Draupnir/blob/main/src/capabilities/StandardUserConsequencesRenderer.tsx

And then copying the use of no-confirm in https://github.com/the-draupnir-project/Draupnir/blob/2ee9f35876c86b7dee681bce1a810d1b5826c0e0/src/safemode/commands/RecoverCommand.tsx

We'd then also want to unify the behavior with that in the banPropagationProtection https://github.com/the-draupnir-project/Draupnir/blob/2ee9f35876c86b7dee681bce1a810d1b5826c0e0/src/protections/BanPropagation.tsx.

Probably not for this PR though.

@nexy7574 nexy7574 marked this pull request as ready for review January 19, 2025 15:49
@Gnuxie Gnuxie merged commit 2300b1e into the-draupnir-project:main Jan 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able unban from all protected rooms when entity not on any of the lists
2 participants