Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/af export #1426

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix/af export #1426

wants to merge 2 commits into from

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Mar 5, 2024

Addresses

Changes

  • soft delete of widget

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a small change.

@@ -386,7 +386,8 @@ def perform_nested_delete_or_update(self, pks_to_delete, model_class, instance,
section=self.instance, # NOTE: Adding this additional filter just to make sure
pk__in=pks_to_delete
)
qs.delete()
qs.update(is_deleted=True)
# qs.delete()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove this comment line.

@sudan45 sudan45 assigned AdityaKhatri and subinasr and unassigned sudan45 May 2, 2024
@sudan45 sudan45 force-pushed the fix/af_export branch 2 times, most recently from a965a0d to dfcb9c5 Compare May 7, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants