Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add sizing key figure #167

Closed
wants to merge 2 commits into from
Closed

Feature/add sizing key figure #167

wants to merge 2 commits into from

Conversation

AdityaKhatri
Copy link
Member

This PR ensures that there are

  • No unnecessary console logs
  • No unwanted comments
  • No typos
  • yarn typecheck shows no issue
  • yarn lint shows no issue

This PR adds one or more new components / utils

  • Add the newly created component and its props to exports
  • Write story for newly created component(s)
  • No empty files

This PR fixes or updates existing components / utils

  • Update / add story to reflect the changes
  • Doesn't introduce breaking changes

Beta release vXX.XX.XX-beta.YY

  • Add a commit for beta release

@AdityaKhatri AdityaKhatri deleted the feature/add-sizing-key-figure branch September 5, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puranban puranban Awaiting requested review from puranban

Assignees

@puranban puranban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaKhatri @puranban