Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add show more button in SelectInput #162

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Add show more button in SelectInput #162

merged 1 commit into from
Mar 9, 2023

Conversation

subinasr
Copy link
Contributor

@subinasr subinasr commented Mar 9, 2023

This PR ensures that there are

  • No unnecessary console logs
  • No unwanted comments
  • No typos
  • yarn typecheck shows no issue
  • yarn lint shows no issue

This PR adds one or more new components / utils

  • Add the newly created component and its props to exports
  • Write story for newly created component(s)
  • No empty files

This PR fixes or updates existing components / utils

  • Update / add story to reflect the changes
  • Doesn't introduce breaking changes

@subinasr subinasr requested a review from AdityaKhatri March 9, 2023 06:09
@AdityaKhatri AdityaKhatri merged commit f478995 into develop Mar 9, 2023
@AdityaKhatri AdityaKhatri deleted the feature/add-show-more-button branch March 9, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaKhatri AdityaKhatri AdityaKhatri approved these changes

Assignees

@AdityaKhatri AdityaKhatri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subinasr @AdityaKhatri