Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disabled functionality in dropdown item #159

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Add disabled functionality in dropdown item #159

merged 1 commit into from
Nov 30, 2022

Conversation

AdityaKhatri
Copy link
Member

  • Add disabled functionality in dropdown item

This PR ensures that there are

  • No unnecessary console logs
  • No unwanted comments
  • No typos
  • [x ] yarn typecheck shows no issue
  • yarn lint shows no issue

This PR adds one or more new components / utils

  • Add the newly created component and its props to exports
  • Write story for newly created component(s)
  • No empty files

This PR fixes or updates existing components / utils

  • Update / add story to reflect the changes
  • Doesn't introduce breaking changes

Beta release vXX.XX.XX-beta.YY

  • Add a commit for beta release

@samshara samshara merged commit 252003d into develop Nov 30, 2022
@AdityaKhatri AdityaKhatri deleted the feature/add-disabled-in-dropdown-item branch November 30, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samshara samshara samshara approved these changes

@tnagorra tnagorra Awaiting requested review from tnagorra

Assignees

@samshara samshara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaKhatri @samshara