Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change url validation in links #152

Merged
merged 1 commit into from
May 24, 2022
Merged

Change url validation in links #152

merged 1 commit into from
May 24, 2022

Conversation

AdityaKhatri
Copy link
Member

This PR ensures that there are

  • No unnecessary console logs
  • No unwanted comments
  • No typos
  • yarn typecheck shows no issue
  • yarn lint shows no issue

This PR adds one or more new components / utils

  • Add the newly created component and its props to exports
  • Write story for newly created component(s)
  • No empty files

This PR fixes or updates existing components / utils

  • Update / add story to reflect the changes
  • Doesn't introduce breaking changes

@AdityaKhatri AdityaKhatri requested a review from tnagorra May 24, 2022 06:17
@AdityaKhatri AdityaKhatri force-pushed the fix/change-url-validation branch from 5a5ed47 to 6fbc635 Compare May 24, 2022 06:22
@tnagorra tnagorra merged commit ef19ffc into develop May 24, 2022
@AdityaKhatri AdityaKhatri deleted the fix/change-url-validation branch July 2, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnagorra tnagorra tnagorra approved these changes

Assignees

@tnagorra tnagorra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaKhatri @tnagorra