Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only sort/filter options when sortFunction is defined #147

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

tnagorra
Copy link
Member

  • Add prop to not move selected options to the top
  • Simplify props for SelectInput and MultiSelectInput

This PR ensures that there are

  • No unnecessary console logs
  • No unwanted comments
  • No typos
  • yarn typecheck shows no issue
  • yarn lint shows no issue

This PR fixes or updates existing components / utils

  • Update / add story to reflect the changes
  • Doesn't introduce breaking changes

- Add prop to not move selected options to the top
- Simplify props for SelectInput and MultiSelectInput
@AdityaKhatri AdityaKhatri merged commit e7d6364 into develop Apr 19, 2022
@AdityaKhatri AdityaKhatri deleted the fix/select-input-options-sorting branch April 19, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants