Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable popup when dismounting #146

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Disable popup when dismounting #146

merged 1 commit into from
Apr 12, 2022

Conversation

tnagorra
Copy link
Member

This PR ensures that there are

  • No unnecessary console logs
  • No unwanted comments
  • No typos
  • yarn typecheck shows no issue
  • yarn lint shows no issue

This PR fixes or updates existing components / utils

  • Update / add story to reflect the changes
  • Doesn't introduce breaking changes

@tnagorra tnagorra requested a review from samshara April 11, 2022 09:18
@tnagorra tnagorra requested a review from AdityaKhatri April 11, 2022 09:18
@AdityaKhatri AdityaKhatri merged commit 2e8eaa1 into develop Apr 12, 2022
@AdityaKhatri AdityaKhatri deleted the fix/popup-behavior-dismount branch April 12, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samshara samshara samshara approved these changes

@AdityaKhatri AdityaKhatri Awaiting requested review from AdityaKhatri

Assignees

@AdityaKhatri AdityaKhatri

@samshara samshara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnagorra @samshara @AdityaKhatri