fix: Option usedefaults re-assign #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```js
var options = {
reverse: true,
usedefaults: false
}
var formatter = new StringMask('+00 (00) 0000-0000')
```
Old code;
```js
usedefaults: this.options.usedefaults || this.options.reverse
```
OR operator (||) return false on left side and return true on right side.
OR for defaults can be convenient because it is short and easy to write but to booleans parameters it was not good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code;
OR operator (||) returns the condition on the right side but the expected one was to have returned the left side.
OR for defaults can be convenient because it is short and easy to write but to booleans parameters it was not good.