Add new intrinsic scope #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an intrinsic ability for all authorizations to read basic information about the corresponding user, and fixes #574
krisbarrett
approved these changes
Jul 21, 2022
Closed
ebrown32
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an intrinsic ability for all authorizations to read basic information about the corresponding user, and fixes #574
This is probably the preferred implementation, but does restrict the evolution of this project in an important way: it effectively removes our ability to use a pairwise identifier algorithm for subject IDs in our OAuth flow, as this provides a trivial bypass. Our internal use case will never depend on this, as we control and sufficiently trust all clients and resources to the extent that we have no privacy concerns in the same way Google or Facebook might when supplying a public OpenID Connect service.
Given that AuthX currently does not support this option, it's doubtful that any other users expect or rely on this functionality. Nevertheless I think it's important to call out.