-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new list #21
Conversation
Visit the preview URL for this PR (updated for commit fd1ff23): https://tcl-71-smart-shopping-list--pr21-vi-ce-form-list-bkn6tf5u.web.app (expires Thu, 22 Feb 2024 09:38:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e7ade9d0f374c4ddb5d7ab6fc541062fc7a1ab4 |
@ocsiddisco , @vivitt , I have added you as assignees to the issue. It's just for the record. Nothing to be done from your side. Now the ball it's on the reviewers' rooftop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
Hi, Well done! 🙂 The work is pretty good so far but there's a small little thing missing. Please, implement the redirection to the list view but with the redirection to the list that was created. It's true it's not explicitly expressed but IMHO, the redirection makes no sense if you are not redirected. Again, you did it pretty well! It's just a small little detail that in fact, I think it must be better described in the issue. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, implement the redirection to the list that was actually created. Once that is done, The PR is ready to be merged. Do not forget to get the changes from the other team!
Good job! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All criteria met, good job!! 🥳
@@ -57,7 +57,7 @@ export function App() { | |||
/> | |||
} | |||
/> | |||
<Route path="/list" element={<List data={data} />} /> | |||
<Route path="/list/:path/:path" element={<List data={data} />} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way we could write the path attribute in the Route
element would be with a template literal which uses listPath
state (/list/${listPath}
), but I don't really know which one would be the best practice. Just a thought in case anyone can chime in, no need to change it.
Description
Add a form in the Home view, so users are able to create a new lists by submitting a new list name. Save a list token in the local storage and redirect the user to the list page when a new list is successfully created. Show an error message when create list fails and when the user submits an empty string.
Related Issue
closes #4
Acceptance Criteria
UI-related tasks:
Data-related tasks:
Type of Changes
feature
Updates
Before
After
Testing Steps / QA Criteria