feat: fallback avatar to initials on image load error #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoxiaozero
reviewed
Nov 27, 2024
| @@ -85,10 +86,10 @@ pub fn Avatar( | |||
| } | |||
| }} | |||
| {move || { | |||
| let src = src.with_value(|s| s.get()); | |||
| let src = src.with_value(|s| if image_failed.get() { None } else { s.get() }); | |||
There was a problem hiding this comment.
After the first image loading fails, modify the src, and the image will never be displayed.
tips: MaybeProp has implemented Copy, and the src prop can remove the StoredValue wrapper.
|
Fixed in #353. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallsback the avatar image to initials when the image fails to load