icon missaligment in message fix #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've just noticed the same issue as described here (#190) and tracked it down to tailwindcss. In the output.css generated by it we have: ``` /* 1. Make replaced elements `display: block` by default. (jensimmons/cssremedy#14) 2. Add `vertical-align: middle` to align replaced elements more sensibly by default. (jensimmons/cssremedy#14 (comment)) This can trigger a poorly considered lint error in some tools but is included by design. */ img, svg, video, canvas, audio, iframe, embed, object { display: block; /* 1 */ vertical-align: middle; /* 2 */ } ``` Your recent change sets the display to inline-block (983e857) and this collides with the 'vertical-align' set by tailwindcss. Changing the vertical-align property to 'top' fixes the misalignment so I think the simplest fix is to add 'vertical-align: top' to icon.css. I don't see it affecting anything else so it should be safe.
|
I feel it would be better to set |
|
Hi, changed as you suggested. Tested and it's working. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just noticed the same issue as described here (#190) and tracked it down to tailwindcss. In the output.css generated by it we have:
Your recent change sets the display to inline-block (983e857) and this collides with the 'vertical-align' set by tailwindcss.
Changing the vertical-align property to 'top' fixes the misalignment so I think the simplest fix is to add 'vertical-align: top' to icon.css. I don't see it affecting anything else so it should be safe.