Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added width property to Modal dialog #112

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Added width property to Modal dialog #112

merged 2 commits into from
Feb 20, 2024

Conversation

glennpierce
Copy link

Added width property to Modal dialog

@luoxiaozero
Copy link
Collaborator

  1. Fixed the animation display issue when opening.
  2. 70% of the width doesn't look good on the big screen.

@glennpierce
Copy link
Author

Thanks. Sorry about the animation. Trying to learn my way around thaw internals.

@luoxiaozero
Copy link
Collaborator

Merge now.

@luoxiaozero luoxiaozero merged commit ae0bbb1 into thaw-ui:main Feb 20, 2024
3 checks passed
@glennpierce
Copy link
Author

Sorry I can't get the dialog to change width now.

or

Shows the same size . Unless I am doing something dumb which is a distinct possibility.

@luoxiaozero
Copy link
Collaborator

Can you write a minimal repetition example?

@luoxiaozero luoxiaozero linked an issue Feb 26, 2024 that may be closed by this pull request
Adjusting Modal width ? #108
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjusting Modal width ?
2 participants
@glennpierce @luoxiaozero