Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make schedule compatible with Django 1.4 #47

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

Natim
Copy link

@Natim Natim commented Apr 20, 2012

Make a new settings.py compatible with Django 1.4, fix bugs that prevent project_sample to starts.
It looks like ajax_ui is the more up-to-date branch since master was merge into at 359:3112232fcb55

I tried to run tests, but it looks that the schedule.json feature is missing.

@Natim
Copy link
Author

Natim commented Apr 20, 2012

I finally find out where was the fixtures schedule.json file and move it so tests can find it.

@domenkozar
Copy link

I would suggest running javascript through some static code analysis tool like JSLint or JSHInt.

@epicserve
Copy link

Okay so I've been trying out Django-schedule and I've tested this pull request. I ran all the unit tests and they all pass, so why hasn't this pull request been merged in? What is the status of this project? I have a site that needs events and I would like to know if I should just copy and paste what I like or fork this project and contribute back. In other words, what is the status of this project? What's the road map going forward? /cc @Natim, @bartekgornym, @thaube, @iElectric

@epicserve epicserve mentioned this pull request Oct 11, 2012
@bartekgorny
Copy link
Collaborator

On Thu, 11 Oct 2012 09:44:06 -0700
epicserve [email protected] wrote:

Okay so I've been trying out Django-schedule and I've tested this
pull request. I ran all the unit tests and they all pass, so why
hasn't this pull request been merged in? What is the status of this
project? I have a site that needs events and I would like to know if
I should just copy and paste what I like or fork this project and
contribute back. In other words, what is the status of this project?
What's the road map going forward? /cc @Natim, @bartekgornym,
@thaube, @iElectric

The project has been abandoned by thauber years ago, taken over by me,
I made big improvements - with a little help from other githubbers -
and then, sorry to say that, I abandoned it too. So if you like it and
would like to do some further development, by all means to it. Fork it
and keep working. Or maybe set up a dedicated github account, like
"djangoschedule", fork as that user and make yourself an admin. What I
don't like about github is that software is tied to a user, so there
is no way to change the chief developer while keeping the url of the
trunk version unchanged.

By the way, it is great to hear someone is really interested in the
project. Would be nice if someone like you brings it back to life. If
you need my assistance, let me know, I would be glad to help. I can't,
for various reasons, head it, but I can certainly help.

Bartek


Reply to this email directly or view it on GitHub:
#47 (comment)

The road to cock-ups is paved with assumptions.
(David Glasgow)

@epicserve
Copy link

@bartekgorny I'm working on a new CMS that will hopefully get open sourced. I think I might must merge it into that project. I've looked at other Django event apps and this seems to be the best one with recurring events. If you know of another one then let me know.

@epicserve
Copy link

@bartekgorny Started doing some work this project. Added twitter bootstrap and renamed the app directory to events because it's seems to be more intuitive in the admin. I pushed up my changes to a dev branch.

@airtonix
Copy link

@epicserve I'd much rather see this project continue as it is without any coupling to a particular front-end framework or being merged into another project I really have no use for. Do one thing and do it well.

in short :

  1. Don't change code to suit bootstrap. Make that a contrib module, preferably as a different repo. (example: I use django-tastypie, zurb-foundation and angularjs)
  2. Keep django-schedule focused on scheduling and events. Don't make any assumptions about what else a project might need. (example: I have my own approach to content management outside of scheduling)

These are of course only my opinions, but I'm fairly sure most others would rather see django-schedule maintain its focus.

@epicserve
Copy link

@airtonix

What is this focus you're talking about? This project hasn't seen any commits in four years. Anyway, django-schedule seems abandoned, I've move the bits and pieces I liked into my own CMS and moved on. I see the front-end of django-schedule, as only a simple example of what you can do with it. So in my humble opinion, it's not a big deal to create an example site using bootstrap. It's easy to understand and examine to see how you can use it. If you don't like the example site, then do something else.

jrutila pushed a commit to jrutila/django-schedule that referenced this pull request Apr 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants