Pass server-side encryption option to minio.StatObject call #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabbrwcky
force-pushed
the
main
branch
3 times, most recently
from
e8ae58b to
1957544
Compare
|
Any updates on this one? |
|
Thanks for this PR! I'd love for this to be merged, my provider is using SSE-C and I cannot use Thanos because of the underlying issue. |
Signed-off-by: Jens Hausherr <[email protected]>
Signed-off-by: Jens Hausherr <[email protected]>
Signed-off-by: Jens Hausherr <[email protected]>
Signed-off-by: Jens Hausherr <[email protected]>
Signed-off-by: Jens Hausherr <[email protected]>
Signed-off-by: Jens Hausherr <[email protected]>
auto-merge was automatically disabled
January 17, 2025 08:03
Head branch was pushed to by a user without write access
|
@JoaoBraveCoding Rebasing onto main has reset the automerge for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing encryption data passed to
minio.StatObject()calls, causing client methodsExists()andAttributes()to fail with a 400 Bad Request error.This may only affects encryption using
SSE-Cbecause here it is the callers responsibility to send the encryption key along with the request. In contrastSSE-KMSandSSE-S3are handled transparently (if the user has permissions to use the key in the casse ofSSE-KMS)Fixes #141
Changes
Bucket.Exists()Bucket.Attributes()Verification
Added E2E-Test that uploads, checks for existence and downloads a file using SSE-C