Add Thanos Query frontend in Query CRD and deployment #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode
force-pushed
the
queryfrontend
branch
from
4a3fc51
to
a9a68f7
Compare
Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode
force-pushed
the
queryfrontend
branch
from
414fa0c
to
085c71a
Compare
philipgough
reviewed
Sep 3, 2024
| Replicas int32 `json:"replicas,omitempty"` | ||
| // CompressResponses enables response compression | ||
| // +kubebuilder:default=true | ||
| CompressResponses bool `json:"compressResponses,omitempty"` |
There was a problem hiding this comment.
nit: But i probably wouldnt even bother exposing this for now, we could stick with the defaults. If you want to keep it here might want to make it a pointer and optional?
There was a problem hiding this comment.
Let's keep it, I think I remember some issue where people were debugging with this.
|
Based on discussion offline with @philipgough I think it makes sense to combine with the Query CRD directly. Will update PR |
Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode
changed the title
Signed-off-by: Saswata Mukherjee <[email protected]>
|
Modified this to be a nested field on Query CRD, but have kept the builder code separate as it is a separate thanos component and not a mode of another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Thanos Query frontend within query crd, which generates cache config if you don't specify