Reset preferences feature with button and reset functionality and cor… #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…responding UI test
|
I apologize - some of the changes in this have code reversions. I'm closing this PR and will submit a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…responding UI test
Related issue
Closes #891
Context / Background
It was recently requested that a feature to reset preferences to their default values would be useful, so this implements that functionality.
What change is being introduced by this PR?
This PR is to review a "Reset" button in the preferences window that returns the preferences to their default values. To indicate that the reset occurred, the button's text changes to "Resetted!" (Attached are screenshots of this functionality). Upon closing the Preferences window, the preferences return to default in the main TTL window. To accomplish this, I added a new button to the src/preferences.html file with styling in the css/styles.css file. The corresponding functionality is implemented in the resetPreferences() method in src/preferences.js. Since it was difficult to update the preferences within the window as soon as the button is pressed and to create a pop-up, the text change on the button can indicate to the user that their action was successful. However, this is a rudimentary solution, and changes can be made by modifying the resetPreferences() method.
How will this be tested?
There has been a unit test added that performs a click on the new button using Jquery, and the corresponding text change verifies that the button responds to the click. Underlying preferences changes can be verified by running the applications, changing some preferences, pressing "Reset", and seeing if the changes occur.