Merge pull request #157 from thackl/fix-156

Fix empty attributes check in read_gff3
thackl · Oct 6, 2023 · 4327a26 · 4327a26
2 parents a34516f + a8bbcf9
commit 4327a26
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/pkgdown.yaml b/.github/workflows/pkgdown.yaml
@@ -14,7 +14,7 @@ jobs:
 
       - uses: r-lib/actions/setup-r@v2
         with:
-          r-version: 4.2.2
+          r-version: 4.3.1
 
       - uses: r-lib/actions/setup-pandoc@v2
 

diff --git a/R/read_gff3.R b/R/read_gff3.R
@@ -184,7 +184,7 @@ tidy_attributes <- function(x, is_gff2=FALSE, keep_attr=FALSE, fix_augustus_cds=
 
   d <- map_df(str_split(x[[9]], "; *"), function(r){
     # handle missing comments
-    if(is.na(r) || str_length(r) == 0)
+    if(all(is.na(r) | str_length(r) == 0))
       return(tibble(.rows=1)) # make sure this df has at least 1 row!
 
     # ignore empty elements caused by trailing or duplicated ";"