Merge pull request moby#47417 from thaJeztah/resolver_improve_logs

libnetwork: resolve: use structured logs for DNS error
thaJeztah · Feb 21, 2024 · c42ae61 · c42ae61
2 parents 9d15415 + d9e082f
commit c42ae61
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/libnetwork/resolver.go b/libnetwork/resolver.go
@@ -576,7 +576,7 @@ func (r *Resolver) exchange(ctx context.Context, proto string, extDNS extDNSEntr
 		UDPSize: dns.MaxMsgSize,
 	}).ExchangeWithConn(query, &dns.Conn{Conn: extConn})
 	if err != nil {
-		r.log(ctx).WithError(err).Errorf("[resolver] failed to query DNS server: %s, query: %s", extConn.RemoteAddr().String(), query.Question[0].String())
+		logger.WithError(err).Error("[resolver] failed to query external DNS server")
 		span.RecordError(err)
 		span.SetStatus(codes.Error, "ExchangeWithConn failed")
 		return nil