Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TH2-4937] add api compatibility compliance check in workflows #245

Open
wants to merge 1 commit into
base: dev-version-5
Choose a base branch
from
Open

[TH2-4937] add api compatibility compliance check in workflows #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/dev-java-publish-sonatype.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@ on:
- version-*

jobs:
api-compatibility-check-core:
uses: th2-net/.github/.github/workflows/japi-compliance-checker.yml@main
with:
projectPath: ./cradle-core
targetJarUrl: https://s01.oss.sonatype.org/content/repositories/releases/com/exactpro/th2/cradle-core/5.0.2-dev/cradle-core-5.0.2-dev.jar
api-compatibility-check-cassandra:
uses: th2-net/.github/.github/workflows/japi-compliance-checker.yml@main
with:
projectPath: ./cradle-cassandra
continueOnError: true
targetJarUrl: https://s01.oss.sonatype.org/content/repositories/releases/com/exactpro/th2/cradle-cassandra/5.0.2-dev/cradle-cassandra-5.0.2-dev.jar
build-job:
uses: th2-net/.github/.github/workflows/compound-java-dev.yml@main
with:
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/dev-release-java-publish-sonatype.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@ on:
- \d+.\d+.\d+-dev

jobs:
api-compatibility-check-core:
uses: th2-net/.github/.github/workflows/japi-compliance-checker.yml@main
with:
projectPath: ./cradle-core
targetJarUrl: https://s01.oss.sonatype.org/content/repositories/releases/com/exactpro/th2/cradle-core/5.0.2-dev/cradle-core-5.0.2-dev.jar
api-compatibility-check-cassandra:
uses: th2-net/.github/.github/workflows/japi-compliance-checker.yml@main
with:
projectPath: ./cradle-cassandra
continueOnError: true
targetJarUrl: https://s01.oss.sonatype.org/content/repositories/releases/com/exactpro/th2/cradle-cassandra/5.0.2-dev/cradle-cassandra-5.0.2-dev.jar
build:
uses: th2-net/.github/.github/workflows/compound-java.yml@main
with:
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/java-publish-sonatype.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,17 @@ on:
- gradle.properties

jobs:
api-compatibility-check-core:
uses: th2-net/.github/.github/workflows/japi-compliance-checker.yml@main
with:
projectPath: ./cradle-core
targetJarUrl: https://s01.oss.sonatype.org/content/repositories/releases/com/exactpro/th2/cradle-core/5.0.2-dev/cradle-core-5.0.2-dev.jar
api-compatibility-check-cassandra:
uses: th2-net/.github/.github/workflows/japi-compliance-checker.yml@main
with:
projectPath: ./cradle-cassandra
continueOnError: true
targetJarUrl: https://s01.oss.sonatype.org/content/repositories/releases/com/exactpro/th2/cradle-cassandra/5.0.2-dev/cradle-cassandra-5.0.2-dev.jar
Comment on lines +15 to +21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the latest non-dev release here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check if we can configure the verification to ignore those classes -> we can just remove cradle-cassandra check from workflow and only check cradle core API. I included both of them just to show how it works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use latest non-dev release we probably will have issues in public API, as I remember we did have some breaking changes. That's why I decided to use lates compatible version, so we can control compatibility starting from it

build:
uses: th2-net/.github/.github/workflows/compound-java.yml@main
with:
Expand Down