Windows 7 #183
Merged
Windows 7 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to build-std twice for debug+release
ZeWaka
requested changes
Jul 21, 2024
| @@ -26,14 +26,14 @@ jobs: | |||
| run: cargo fmt -- --check | |||
|
|
|||
| - name: Build (release) (default features) | |||
| run: cargo build --target i686-pc-windows-msvc --locked --release | |||
| run: cargo build -Z build-std --target i686-win7-windows-msvc --locked --release | |||
There was a problem hiding this comment.
For those unaware of why we are building std and thus using a nightly toolchain,
rust-lang/rust#118150
ZeWaka
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades all Cargo packages, plus replaces reqwest with ureq because reqwest relies on tokio, which relies on an old version of mio, which relies on a specific version of windows-targets, which whatever it is it didn't work
Doesn't do anything about the 32/64 bit thing, someone else can do that in a separate PR
Solves windows 7 part of #182