Remove @inlinable and @usableFromInline decorations

I don't think they improve performance that much, and they have deep consequence on ABI stability, so I guess it's better to remove them now, when the library is still young.
tgrapperon · Jun 8, 2021 · f77d967 · f77d967
1 parent 187eb5f
commit f77d967
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 15 deletions.
diff --git a/Sources/ComposableEnvironment/ComposableEnvironment.swift b/Sources/ComposableEnvironment/ComposableEnvironment.swift
@@ -2,16 +2,12 @@ import Foundation
 open class ComposableEnvironment {
   public required init() {}
 
-  @usableFromInline
   var dependencies: ComposableDependencies = .init()
 
-  @usableFromInline
   var hasReceivedDependenciesFromParent: Bool = false
 
-  @usableFromInline
   var knownChildren: Set<AnyKeyPath> = []
 
-  @inlinable
   @discardableResult
   public func with<V>(_ keyPath: WritableKeyPath<ComposableDependencies, V>, _ value: V) -> Self {
     dependencies[keyPath: keyPath] = value

diff --git a/Sources/ComposableEnvironment/Dependencies.swift b/Sources/ComposableEnvironment/Dependencies.swift
@@ -5,16 +5,13 @@ public protocol DependencyKey {
 }
 
 public struct ComposableDependencies {
-  @usableFromInline
   var values = [AnyHashableType: Any]()
 
-  @inlinable
   public subscript<T>(_ key: T.Type) -> T.Value where T: DependencyKey {
     get { values[AnyHashableType(key)] as? T.Value ?? key.defaultValue }
     set { values[AnyHashableType(key)] = newValue }
   }
 
-  @inlinable
   mutating func mergeFromUpstream(_ upstreamDependencies: ComposableDependencies) {
     // We should preserve existing overrides
     values = values.merging(upstreamDependencies.values,

diff --git a/Sources/ComposableEnvironment/Dependency.swift b/Sources/ComposableEnvironment/Dependency.swift
@@ -1,7 +1,6 @@
 /// Use this property wrapper to declare depencies in a ComposableEnvironment subclass.
 @propertyWrapper
 public struct Dependency<Value> {
-  @inlinable
   public static subscript<EnclosingSelf: ComposableEnvironment>(
     _enclosingInstance instance: EnclosingSelf,
     wrapped wrappedKeyPath: ReferenceWritableKeyPath<EnclosingSelf, Value>,
@@ -18,7 +17,6 @@ public struct Dependency<Value> {
     }
   }
 
-  @usableFromInline
   var keyPath: KeyPath<ComposableDependencies, Value>
 
   public init(_ keyPath: KeyPath<ComposableDependencies, Value>) {

diff --git a/Sources/ComposableEnvironment/DerivedEnvironment.swift b/Sources/ComposableEnvironment/DerivedEnvironment.swift
@@ -1,6 +1,5 @@
 @propertyWrapper
 public final class DerivedEnvironment<Value> where Value: ComposableEnvironment {
-  @inlinable
   public static subscript<EnclosingSelf: ComposableEnvironment>(
     _enclosingInstance instance: EnclosingSelf,
     wrapped wrappedKeyPath: ReferenceWritableKeyPath<EnclosingSelf, Value>,
@@ -21,7 +20,6 @@ public final class DerivedEnvironment<Value> where Value: ComposableEnvironment
     }
   }
 
-  @usableFromInline
   var environment: Value
 
   public init(wrappedValue: Value) {

diff --git a/Sources/ComposableEnvironment/Internal/AnyType.swift b/Sources/ComposableEnvironment/Internal/AnyType.swift
@@ -1,22 +1,18 @@
-@usableFromInline
 struct AnyHashableType: Hashable {
   private var type: Any
   private var isEqualTo: (AnyHashableType) -> Bool
   private var hashInto: (inout Hasher) -> Void
 
-  @usableFromInline
   init<T>(_ type: T.Type) {
     self.type = type
     isEqualTo = { $0.type is T.Type }
     hashInto = { $0.combine(String(describing: T.self)) }
   }
 
-  @usableFromInline
   func hash(into hasher: inout Hasher) {
     hashInto(&hasher)
   }
 
-  @usableFromInline
   static func == (lhs: AnyHashableType, rhs: AnyHashableType) -> Bool {
     lhs.isEqualTo(rhs)
   }