add skel plugin for code sharing #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in.go Add YAML Plugin skel.go for plugin/yaml
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ypes Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes significant changes to the plugin system, particularly around the implementation of the
SkelPluginand the removal of redundant code. The most important changes include the creation of theSkelPluginclass, refactoring existing plugins to useSkelPlugin, and the removal of unnecessary methods and code.Creation of
SkelPlugin:libplugin/skel.go: Introduced theSkelPluginclass with methods for creating configurations, handling password and public key callbacks, and verifying host keys.Refactoring existing plugins:
plugin/docker/docker.go: Removed old methods and refactored the plugin to useSkelPlugin. This includes changes in themainfunction to utilizeSkelPluginfor creating configurations. [1] [2] [3] [4]plugin/kubernetes/kubernetes.go: Similar to the Docker plugin, the Kubernetes plugin was refactored to useSkelPlugin, and redundant methods were removed. [1] [2] [3] [4] [5]Removal of redundant code:
.goreleaser.yaml: Removed theplugin_workingdirbykeybuild configuration as it is no longer needed.plugin/docker/skel.go: Added a new file to support the Docker plugin's integration withSkelPlugin.libplugin/util.go: Simplified the port parsing logic inSplitHostPortForSSHfunction.These changes streamline the plugin architecture, making it more modular and easier to maintain.