This repository has been archived by the owner on Apr 13, 2021. It is now read-only.
Prefix child db by threadid when starting #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carson Farmer <[email protected]>
carsonfarmer
added
bug
carsonfarmer
commented
Jul 22, 2020
| const threadID = opts.threadID ?? this.threadID ?? ThreadID.fromRandom() | ||
| let info: ThreadInfo | ||
| try { | ||
| // DANGER: If we don't have the key info locally here already, we're out of luck! |
There was a problem hiding this comment.
This is actually a fundamental issue with our current Database implementation. The key info is likely not recoverable at this point. Right now, we assume this isn't the case, and that we have the thread info cached locally. Moving to #414 will fix this issue, so it might not be worth worry about this too much right now.
| new Key(this.threadID.toString()) | ||
| ) | ||
| // Open "new" store, which may in fact already exist | ||
| await this.child.open() |
There was a problem hiding this comment.
We've deferred start until the last minute here, this makes it possible to prefix all our keys since we might not know the thread id until now.
| throw new Error("Unable to obtain thread id") | ||
| // Replace default child store with store prefixed by thread id | ||
| this.child = new DomainDatastore( | ||
| this.child, |
There was a problem hiding this comment.
I don't think this'll be an issue :P
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carson Farmer [email protected]
Description
This PR changes the internals of how we "start" Databases. Now, the actual "opening" of the database is deferred until it is actually "started". Additionally, while we can "create" a database and its underlying components (dispatcher, event handler, etc) at construction time, none of this stuff is turned on until we actually start it. Additionally, all DB keys are prefixed by the threadid in a transparent way. So that, in theory, a user doesn't really need to worry about threadid at all. Additionally, this makes the database "name" (which is really just sugar for the developer) default to "thread.db". For developer who want to "sandbox" their db from other user dbs, they can specify their own name.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
All existing tests should pass. Additionally, some previous behavior that was expected to fail, should no longer fail, so some checks for this were actually removed. With that in mind, some additional tests should be applied here.
Checklist: