Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pages/grid after switching single page step #3957

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

octaeder
Copy link
Contributor

@octaeder octaeder commented Jan 19, 2025

The PR fixes following two cases (alway start with non singlePageOffset). Left half of the images from master, right half fixed (s. details in txs window title).

  1. Set non continuous, pageOffset>0. Scroll to top. Now setting singlePageStep moves pages and leaves empty grid faces at lower right of the grid:

    grafik
    click to enlarge

    grafik
    click to enlarge

    This issue is a direct consequence of fixing calculation of visible pages/pages list fix pdf-viewer's page display in non continuous mode #3952. This is fixed with reloadPage.

  2. Set continuous, pageOffset>0 and last grid row has at most pageOffset many pages (f.ex. gridx=3 and 11 pages). Scroll to end. Then setting singlePageStep moves last pages to previous line and last grid row is empty. Have a close look at the different scrollbars to the left and right. To the left you can sroll down to the empty row. But overscroll should't be possible with continuous. Also, returning back works with fixed version: Switching to non singlePageStep brings back the row on the right side:

    grafik
    click to enlarge

    grafik
    click to enlarge

    This is fixd with updateScrollBars. I see no difference when removing delayedUpdate.

@sunderme sunderme merged commit 3ad4ab1 into texstudio-org:master Jan 20, 2025
7 checks passed
@sunderme
Copy link
Member

thanks

@octaeder octaeder deleted the singlePageStep branch January 20, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants