wasi: nonblocking pipes on Windows #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve tetratelabs#1500 with a simple observation, i.e. we really need non-blocking I/O only for pipes and sockets. Now, for sockets we can use WinSock select, as for pipes, select_windows.go already imports PeekNamedPipe. We combine PeekNamedPipe with a blocking Read only for those cases when PeekNamedPipe returns n > 0, which means a Read of n bytes won't block. We special case n == 0 to return EAGAIN and ERROR_BROKEN_PIPE as a non-failure (EOF reached). We also introduce `isNonblock(f)` function, specialized on Windows to also check if the file is ModeNamedPipe; otherwise we would default to blocking anyway. Signed-off-by: Edoardo Vacchi <[email protected]>
ncruces
approved these changes
Jul 9, 2023
codefromthecrypt
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve #1500 with a simple observation, i.e. we really need non-blocking I/O only for pipes and sockets.
Now, for sockets we can use WinSock select, as for pipes, select_windows.go already imports PeekNamedPipe.
We combine PeekNamedPipe with a blocking Read only for those cases when PeekNamedPipe returns n > 0, which means a Read of n bytes won't block.
We special case n == 0 to return EAGAIN and
ERROR_BROKEN_PIPE as a non-failure (EOF reached).
We also introduce
isNonblock(f)function, specialized on Windows to also check if the file is ModeNamedPipe; otherwise we would default to blocking anyway.