-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support zh-Hans #1158
base: main
Are you sure you want to change the base?
feat: support zh-Hans #1158
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @xupea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we review this, I would like to hear more opinions if we should add more languages to the docs or not.
Because this will also have an impact (read take time) in the future.
If the majority approves, some "ground rules" would be useful to add to the contributing guidelines.
I believe translations is a good idea and 100% agree that we should add ground rules for the contribution guidelines and talk about it a bit before merging :) |
Docusaurus has good i18n support. Although it's likely there will be some divergence in the docs for different languages, it seems like a good thing to do. It would be nice to have a "translation lead" for each language that stays subscribed to this repo and tries to keep up with changes to the docs as the APIs change. Community contributions also welcome. |
What happened to the translation initiative for the project? I think this will increase the usage and access of the |
@nazarepiedady I didn't get the chance to review this one. I'll do my best to get to it soon :) |
@MatanBobi we need this feature as soon as possible, |
Do we need to move English into |
@nickmccurdy accordingly to the preview of the website, it seems to |
Two major changes: