Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update setup to include import statement #1153

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

edmundsj
Copy link
Contributor

@edmundsj edmundsj commented Oct 5, 2022

I spent an hour trying to figure out what was wrong with my code, not realizing that user-events was an unnamed export. Please put an import statement somewhere in the docs, if not here, to save poor idiots like myself.

I spent an hour trying to figure out what was wrong with my code, not realizing that user-events was an unnamed export. Please put an import statement somewhere in the docs, if not here, to save poor idiots like myself.
@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 82521a5
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/633df658a8a7860009653713
😎 Deploy Preview https://deploy-preview-1153--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon changed the title Update setup to include import statement docs: Update setup to include import statement Oct 6, 2022
@eps1lon eps1lon merged commit d36b012 into testing-library:main Oct 6, 2022
@eps1lon
Copy link
Member

eps1lon commented Oct 6, 2022

@all-contributors Add @edmundsj for docs

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @edmundsj! 🎉

@ph-fritsche
Copy link
Member

I think it's odd to include the import specifically in this paragraph.
If it isn't obvious by the declarations, we should add it in intro and/or install like #1143.
(Are there really IDEs that don't display the types we deliver with the package?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import userEvent after installing user-event
3 participants