feat(fireEvent): improve code for definable read-only properties

testing-library · Oct 11, 2022 · b901f7f · b901f7f
1 parent eb800af
commit b901f7f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/__tests__/events.js b/src/__tests__/events.js
@@ -383,6 +383,8 @@ test('assigns read-only target properties', () => {
 
   expect(node.scrollWidth).toBe(0)
   fireEvent.scroll(node, {target: {scrollWidth: 10}})
+
+  expect(spy).toHaveBeenCalledTimes(1)
   expect(node.scrollWidth).toBe(10)
 })
 

diff --git a/src/events.js b/src/events.js
@@ -46,14 +46,13 @@ function createEvent(
     })
   }
 
-  const modifiableProperties = {}
+  // Make read-only properties of events specifiable for tests.
   Object.keys(targetProperties).forEach(key => {
-    modifiableProperties[key] = {
+    Object.defineProperty(node, key, {
       value: targetProperties[key],
       writable: true,
-    }
+    })
   })
-  Object.defineProperties(node, modifiableProperties)
 
   const window = getWindowFromNode(node)
   const EventConstructor = window[EventType] || window.Event