Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support with_cmd for GenericImage #703

Closed

Conversation

tisonkun
Copy link

This closes #701.

@DDtKey I'm new to here so perhaps you can tell me some conveniences and best practices if I miss them :D

Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for testcontainers-rust ready!

Name Link
🔨 Latest commit d289269
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-rust/deploys/669c52cd2c551c0008d95dc4
😎 Deploy Preview https://deploy-preview-703--testcontainers-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tisonkun
Copy link
Author

Seems some logic conflicts. Let me try to debug locally.

Copy link
Collaborator

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remembered why the cmd isn't exposed as part of the GenericImage.

It produces fully duplicative methods with ImageExt for no reason actually. Currently only essential options are provided as part of GenericImage api (which are not available within ImageExt)

Also, it would lead to unnecessary name collisions (not critical, but also - for no reason).

Let's say if we add cmd, why other options shouldn't be available? There is no benefit, but unnecessary confusion, actually

Moreover, the common way to go is usually implementation of custom Image (or use provided) rather than using generic one.

I apologize for this, but I have to reject the PR unless there is a strong reason for this.

Thank you 🙏

@tisonkun tisonkun closed this Jul 22, 2024
@tisonkun
Copy link
Author

Sounds reasonable. Never mind :D

@tisonkun tisonkun deleted the with-endpoint-for-generic-image branch July 22, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support customize CMD for GenericImage
2 participants