Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mailpit as module #1134

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

feslima
Copy link

@feslima feslima commented Mar 2, 2024

What does this PR do?

Adds Testcontainers.Mailpit as a module to the project.

Why is it important?

Mailpit is an extremely useful tool for testing email related features and I think having it as a module to use inside the Testcontainers .NET C# ecosystem is worth the effort.

Related issues

Didn't find any.

How to test this PR

I've added simple a test that ensures the SMTP and Web servers are working accordingly by sending the email and querying the REST api for that specific email.

To run this test in your shell:

dotnet test "tests/Testcontainers.Mailpit.Tests/Testcontainers.Mailpit.Tests.csproj"

Follow-ups

If this PR is acceptable, I think there is still some tidying-up of the .sln files to keep consistency as I've seen done in other merged PRs.

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit a72409a
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/65e36cda620886000857e768
😎 Deploy Preview https://deploy-preview-1134--testcontainers-dotnet.netlify.app/modules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added enhancement New feature or request module An official Testcontainers module labels Mar 11, 2024
@HofmeisterAn
Copy link
Collaborator

Sorry for the late response. I will try to review the PR next week ✌️.

@HofmeisterAn
Copy link
Collaborator

Relates to #1153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants