Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Ruby 2.3 and aws-sdk-ec2 #419

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Require Ruby 2.3 and aws-sdk-ec2 #419

merged 2 commits into from
Mar 15, 2019

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Oct 1, 2018

Stop depending on the monolithic AWS sdk when we only need the ec2 SDK, which is tiny in comparison.

This is basically #339, but only with the aws / ruby change and w/o the various chefstyle updates.

Signed-off-by: Tim Smith [email protected]

@jesseadams
Copy link

@tas50 What is the status of this change?

@tas50
Copy link
Member Author

tas50 commented Nov 1, 2018

We have the coordinate the change with inspec and chef provisioning aws. This part is ready when they are.

@jesseadams
Copy link

Is there anyway I can help push this along?

@jesseadams
Copy link

@tas50 Any chance we can get this coordinated soon? This keeps biting us!

@tas50 tas50 mentioned this pull request Dec 21, 2018
@ChrisPetr0
Copy link

I agree, this is quite troublesome and time consuming to depend on all the gems in aws-sdk (v3) without the need for them.

@jtulick
Copy link

jtulick commented Jan 10, 2019

I agree, this is quite troublesome and time consuming to depend on all the gems in aws-sdk (v3) without the need for them.

Same here, could we get an update on this?

@cheeseplus cheeseplus mentioned this pull request Jan 24, 2019
@jesseadams
Copy link

@tas50 It's been 4 months. Is this going to get merged in soon or should we drop kitchen for testing and do something else?

@cheeseplus
Copy link
Contributor

cheeseplus commented Feb 13, 2019

Test-kitchen has even less maintainers than it ever has, it's effectively a skeleton crew of part time folks at this point and they are trying their best to coordinate the upstream changes with the other products in ChefDK.

It's not on @tas50's shoulders and using a vague threat of dropping kitchen is bad form and isn't a great way to get help. Don't be that person.

(EDIT: the physics only change here if you are a paying customer of Chef and raise up the need for this via official channels, that might get you something - otherwise it's just being rude to already overworked and underappreciated folks)

@jeffbyrnes
Copy link

I appreciate @jesseadams’ frustration; they’ve been struggling with this for some time (and have comments strewn over multiple issues).

I’m going to take a peek at the other two repos & see if I can contribute while I’m still waiting to start a new gig next week; maybe I can move this along a little bit, or at least document what has to happen on those projects & create some clarity.

@jesseadams
Copy link

@cheeseplus I apologize if that came across as angry, offensive, or appeared as a threat. That was not my intention. I just need to know whats going on so we can plan accordingly. I know @tas50 is a busy guy, too.

@jeffbyrnes Please let me know if I can help in any way (testing, etc.). Thanks!

@tas50
Copy link
Member Author

tas50 commented Feb 13, 2019

As many things go here this is actually much more complex than just this simple PR. We needed to make sure our entire ecosystem of tools in ChefDK / Workstation were on aws-sdk-v3 and doing that resulted in some pretty significant changes to some. For InSpec we first created a plugin system and broke out all AWS functionality into it's own plugin. That plugin is a ground up rewrite that uses the new SDK and a bunch of other core changes to InSpec. That work is wrapping up and that allows us to ship InSpec / kitchen-ec2 together in a major DK release this April that includes the v3 gem. It can't go in the current release because it's a major breaking change that may impact other uses in the current DK.

@jeffbyrnes
Copy link

jeffbyrnes commented Feb 13, 2019

Well! That is great news, in spite of the need for continued patience.

So it’s easier to jump off to the other relevant work, here’s all the issues & PRs I found that are involved in this:

@Zordrak
Copy link

Zordrak commented Mar 15, 2019

function clean_kitchen {
  kitchen ${@} 2> >(grep --color=always -v 'constant Struct::Tms is deprecated' >&2)
}

Stop depending on the monolithic AWS sdk when we only need the ec2 SDK, which is tiny in comparison.

Signed-off-by: Tim Smith <[email protected]>
Fix style for the latest chefstyle

Signed-off-by: Tim Smith <[email protected]>
@tas50 tas50 merged commit 3fb421a into master Mar 15, 2019
@tas50 tas50 deleted the aws_v3 branch January 30, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants