Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wasmtime #694

Merged
merged 1 commit into from
Jan 4, 2025
Merged

update wasmtime #694

merged 1 commit into from
Jan 4, 2025

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Jan 2, 2025

Just updating the wasmtime version on the cargo side plus a few mix deps as well. There is a flacky test that uses get-time, for me it's flaky but looks like the api itself is not consistently returning good results.

on https(1 in 3 has a good reply):

 curl https://worldtimeapi.org/api/timezone/America/New_York
curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to worldtimeapi.org:443

 curl https://worldtimeapi.org/api/timezone/America/New_York
{"utc_offset":"-05:00","timezone":"America/New_York","day_of_week":4,"day_of_year":2,"datetime":"2025-01-02T14:12:24.862813-0
5:00","utc_datetime":"2025-01-02T19:12:24.862813+00:00","unixtime":1735845144,"raw_offset":-18000,"week_number":1,"dst":false
,"abbreviation":"EST","dst_offset":0,"dst_from":null,"dst_until":null,"client_ip":"82.154.180.182"

on http (about 1 in 10 has a good reply):

curl http://worldtimeapi.org/api/timezone/America/New_York
curl: (52) Empty reply from server

curl http://worldtimeapi.org/api/timezone/America/New_York
{"utc_offset":"-05:00","timezone":"America/New_York","day_of_week":4,"day_of_year":2,"datetime":"2025-01-02T14:13:12.565825-0
5:00","utc_datetime":"2025-01-02T19:13:12.565825+00:00","unixtime":1735845192,"raw_offset":-18000,"week_number":1,"dst":false
,"abbreviation":"EST","dst_offset":0,"dst_from":null,"dst_until":null,"client_ip":"82.154.180.182"}

Copy link
Owner

@tessi tessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and help in maintaining wasmex!

Your changes look great, happy to merge when CI agrees :)

}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

@tessi
Copy link
Owner

tessi commented Jan 4, 2025

Regarding the flaky: which test specifically is it?

I understand that your PR doesn't address that issue, right? Relying on external http calls during test runs doesn't sound like the best idea anyways. We should fix that.

@tessi tessi merged commit 649bbe4 into tessi:main Jan 4, 2025
13 checks passed
@mangas
Copy link
Contributor Author

mangas commented Jan 4, 2025

Regarding the flaky: which test specifically is it?

I understand that your PR doesn't address that issue, right? Relying on external http calls during test runs doesn't sound like the best idea anyways. We should fix that.

This this, one https://github.com/tessi/wasmex/blob/main/test/components/wasi_test.exs#L6

It seems fairly harmless but yeah I guess it could be mocked perhaps?

@mangas mangas deleted the update-wasmtime branch January 4, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants