Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustler 0.30 & latest Elixir/Erlang #511

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Rustler 0.30 & latest Elixir/Erlang #511

merged 10 commits into from
Mar 6, 2024

Conversation

RoyalIcing
Copy link
Collaborator

@RoyalIcing RoyalIcing commented Jan 17, 2024

Hey! I saw there’s a new version of Rustler, so here’s an update to it. I believe it’s just a bump with minor changes.

I can make it in a separate PR if you prefer: there’s also updates to Elixir/Erlang so I’ve updated those too.

@RoyalIcing RoyalIcing requested a review from tessi January 17, 2024 10:34
@RoyalIcing RoyalIcing self-assigned this Jan 17, 2024
@RoyalIcing RoyalIcing added the dependencies Pull requests that update a dependency file label Jan 17, 2024
@tessi
Copy link
Owner

tessi commented Jan 17, 2024

@RoyalIcing this looks great! thanks for taking care! ❤️

there is just that weird dialyzer error. and just staring at the error output I sometimes wonder if it's worth having it. I cheer for elixirs type system to advance fast :)

@RoyalIcing
Copy link
Collaborator Author

@tessi I'll have a look at the error, I missed that. Yeah I much prefer first-party type systems!

@tessi
Copy link
Owner

tessi commented Mar 5, 2024

whoar, I guess I'll throw out dialyzer. the benefit it brings doesn't feel big enough compared to the burden of maintenance it introduces.

@RoyalIcing
Copy link
Collaborator Author

whoar, I guess I'll throw out dialyzer. the benefit it brings doesn't feel big enough compared to the burden of maintenance it introduces.

Yeah it only seems to be happening with the latest Elixir? It's not saying which line the problem is coming from so it's difficult to debug. I couldn't see a function matching the erring pattern at first glance.

@tessi
Copy link
Owner

tessi commented Mar 6, 2024

alright, dialyzer is gone for good. this PR is green. again. Thanks a ton @RoyalIcing 💜

@tessi tessi merged commit 5f3f2fe into main Mar 6, 2024
17 checks passed
@tessi tessi deleted the rustler-0.30 branch March 6, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants