Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LFP dashboards #3954

Closed

Conversation

jheredianet
Copy link
Contributor

This is a proposal to remove the "LFP" dashboards that have been in the project for a long time, but they only cause confusion to users and I see that they do not really contribute anything new. What's more, they are a clone from the core dashboards that have already been updated several times and have become obsoletes.

It has been commented several times in different posts (which I refer to at the end) of the intention to remove them and have the code modified so that it tries to detect the type of battery that the car has automatically and that the panels do I calculate them using that data. But even so, I don't see the need to make special calculations for the type of battery since the car itself is already responsible for providing that data specifically and we don't need to categorize it again.

The only thing I have seen is that Teslamate, to consider the efficiency of the charges, only considers charges that last longer than 10 minutes and are less than 95% SOC (because we already know that after that the car is no longer efficient at charging) which is correct, and since those with LFP batteries usually charge at 100%, that's where the controversy comes from that the formulas have to change.

As a developer of the "Battery Health" dashboard I receive many questions regarding the LFP dashboards and why they show different values. In my humble opinion, the LFP dashboards should not have been approved from the beginning. I run a Spanish group of Teslamate enthusiast (more than 500 users) and everyone uses the core dashboards directly instead of the LFP ones because the data is more accurate.

If you consider that the LFP dashboards should not be removed, I understand and respect that. If so, please feel free to reject this PR. Thank you

These are other posts talking about this:

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 1f5ed3f
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/6669a85d17be3d0008582b8a
😎 Deploy Preview https://deploy-preview-3954--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KILYBMW
Copy link

KILYBMW commented Jun 12, 2024

Good idea.
Those dashboards don't add value because the main ones (NO-LFP) have updated data and take everything necessary into account, regardless of the vehicle's battery type.

@RafaG
Copy link

RafaG commented Jun 12, 2024

Great Idea! I really don't understand why we have separate dashboards for LFP batteries

@JakobLichterfeld JakobLichterfeld added the area:dashboard Related to a Grafana dashboard label Jun 15, 2024
@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Jun 15, 2024

I tend to agree. @swiffer what do you think about removing LFP dashboards?

@swiffer
Copy link
Contributor

swiffer commented Jun 16, 2024

@JakobLichterfeld Supporting the idea of removing them. The changes that have been made to the LFP variants back then are listed here:

#3438 (comment)

@KILYBMW - visualization changes have not been incorporated into the main ones - so there is still value but having them diverged over time is bad.

as stated in #3438 we should come back to one dashboard and utilize config / queries instead of adding additional dashboards.

Grafana 11 supports setting multiple thresholds by config query results. This was not possible in the past (when those dashboards have been added).

So for example to remove upper caps from overview dashboard battery level gauge (in case of LFP) is possible via query - the only thing needed is somehow storing battery type per car and using that in the queries going forward. concepts for that are drafted here: #3524 (comment)

grafik

grafik

@JakobLichterfeld
Copy link
Collaborator

solved by #3966

@jheredianet jheredianet deleted the remove_lfp_dashboards branch June 18, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants