-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LFP dashboards #3954
Remove LFP dashboards #3954
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Good idea. |
Great Idea! I really don't understand why we have separate dashboards for LFP batteries |
I tend to agree. @swiffer what do you think about removing LFP dashboards? |
@JakobLichterfeld Supporting the idea of removing them. The changes that have been made to the LFP variants back then are listed here: @KILYBMW - visualization changes have not been incorporated into the main ones - so there is still value but having them diverged over time is bad. as stated in #3438 we should come back to one dashboard and utilize config / queries instead of adding additional dashboards. Grafana 11 supports setting multiple thresholds by config query results. This was not possible in the past (when those dashboards have been added). So for example to remove upper caps from overview dashboard battery level gauge (in case of LFP) is possible via query - the only thing needed is somehow storing battery type per car and using that in the queries going forward. concepts for that are drafted here: #3524 (comment) |
solved by #3966 |
This is a proposal to remove the "LFP" dashboards that have been in the project for a long time, but they only cause confusion to users and I see that they do not really contribute anything new. What's more, they are a clone from the core dashboards that have already been updated several times and have become obsoletes.
It has been commented several times in different posts (which I refer to at the end) of the intention to remove them and have the code modified so that it tries to detect the type of battery that the car has automatically and that the panels do I calculate them using that data. But even so, I don't see the need to make special calculations for the type of battery since the car itself is already responsible for providing that data specifically and we don't need to categorize it again.
The only thing I have seen is that Teslamate, to consider the efficiency of the charges, only considers charges that last longer than 10 minutes and are less than 95% SOC (because we already know that after that the car is no longer efficient at charging) which is correct, and since those with LFP batteries usually charge at 100%, that's where the controversy comes from that the formulas have to change.
As a developer of the "Battery Health" dashboard I receive many questions regarding the LFP dashboards and why they show different values. In my humble opinion, the LFP dashboards should not have been approved from the beginning. I run a Spanish group of Teslamate enthusiast (more than 500 users) and everyone uses the core dashboards directly instead of the LFP ones because the data is more accurate.
If you consider that the LFP dashboards should not be removed, I understand and respect that. If so, please feel free to reject this PR. Thank you
These are other posts talking about this: