Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geocoder.ex to include Territories #3868

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattew124
Copy link

The address returned by the following link returns a territory in place of state so I have added state aliases to include this information:

https://nominatim.openstreetmap.org/reverse?format=xml&lat=-35.1604&lon=149.1049&zoom=19&addressdetails=1

The address returned by the following link returns Territory instead of state so I have added state aliases to include this information:

https://nominatim.openstreetmap.org/reverse?format=xml&lat=-35.1604&lon=149.1049&zoom=19&addressdetails=1
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 84ce69e
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/662a05d2ea310400081a50b0
😎 Deploy Preview https://deploy-preview-3868--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mattew124
Copy link
Author

Once this change is applied is it possible to update existing data?

@JakobLichterfeld JakobLichterfeld added the area:openstreetmap Related to OpenStreetMap label Apr 27, 2024
@JakobLichterfeld
Copy link
Collaborator

Thanks for your suggestion!

Once this change is applied is it possible to update existing data?

You can code a migration step which can add it for old data, not sure about the performance in this case tbh.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label May 28, 2024
@DrMichael
Copy link
Collaborator

@JakobLichterfeld I'd say, this PR makes sense....

@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented May 28, 2024

@JakobLichterfeld I'd say, this PR makes sense....

Sure, but it is neither complete, nor backward compatible, nor proven to work worldwide. And is stale by OP.

@github-actions github-actions bot removed the Stale label May 29, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions.

@JakobLichterfeld
Copy link
Collaborator

nor proven to work worldwide

No Territory for adresses in germany. For example: https://nominatim.openstreetmap.org/reverse?format=xml&lat=48.95662066509727&lon=9.245291956117336&zoom=19&addressdetails=1

@JakobLichterfeld
Copy link
Collaborator

Copy link
Contributor

github-actions bot commented Aug 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Aug 6, 2024
@JakobLichterfeld JakobLichterfeld marked this pull request as draft October 21, 2024 12:09
@github-actions github-actions bot removed the Stale label Oct 22, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants