fix: geometry edit tools and styling #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
null |
KaiVolland
reviewed
Nov 8, 2024
Comment on lines
225
to
230
| <ToggleGroup | ||
| selected={selected} | ||
| onChange={(_evt: any, value: string | undefined) => { | ||
| setSelected(value) | ||
| }} | ||
| > |
There was a problem hiding this comment.
Suggested change
| <ToggleGroup | |
| selected={selected} | |
| onChange={(_evt: any, value: string | undefined) => { | |
| setSelected(value) | |
| }} | |
| > | |
| <ToggleGroup | |
| selected={selected} | |
| onChange={(_evt: any, value: string | undefined) => { | |
| setSelected(value) | |
| }} | |
| > |
src/components/EditFeatureDrawer/EditFeatureGeometryToolbar/index.tsx
Outdated
Show resolved
Hide resolved
thanks for the review, the styling changes were more about restoring old styles which were no longer available due to the updates in the next version. I still generally looks the same. |
KaiVolland
approved these changes
Nov 11, 2024
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets geometry edit tools as inactive until activated by the users and applies styling fixes.