fix: geometry edit tools and styling #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
null |
KaiVolland
reviewed
Nov 8, 2024
Comment on lines
225
to
230
| <ToggleGroup | ||
| selected={selected} | ||
| onChange={(_evt: any, value: string | undefined) => { | ||
| setSelected(value) | ||
| }} | ||
| > |
There was a problem hiding this comment.
Suggested change
| <ToggleGroup | |
| selected={selected} | |
| onChange={(_evt: any, value: string | undefined) => { | |
| setSelected(value) | |
| }} | |
| > | |
| <ToggleGroup | |
| selected={selected} | |
| onChange={(_evt: any, value: string | undefined) => { | |
| setSelected(value) | |
| }} | |
| > |
src/components/EditFeatureDrawer/EditFeatureGeometryToolbar/index.tsx
Outdated
Show resolved
Hide resolved
thanks for the review, the styling changes were more about restoring old styles which were no longer available due to the updates in the next version. I still generally looks the same. |
KaiVolland
approved these changes
Nov 11, 2024
Thanks for the review! |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
## [9.0.0-next.2](v9.0.0-next.1...v9.0.0-next.2) (2024-11-27) ### Features * add XYZ and Stamen/Stadia serializers ([a0141cf](a0141cf)) * adds reroute link from error page to login ([133c46c](133c46c)) * init ImportDataModal (and fix minor styling issues) ([08b1016](08b1016)) * parse map interactions ([4525420](4525420)) * remove static loading text, add loading indicator and minor css cleanup ([92b0ec7](92b0ec7)) ### Bugfixes * add layer to target group before adding it to the map ([4279c64](4279c64)) * cursor jumps on keystroke ([691fe6f](691fe6f)) * geometry edit tools and styling ([#1762](#1762)) ([1b6b833](1b6b833)) * layout and styling ([b8ee0df](b8ee0df)) * make metadata configurable ([e8b5d3a](e8b5d3a)) * remove empty element and add check ([a06b8ee](a06b8ee)) * restore the initial value ([a73e05b](a73e05b)) * rewording of translation text ([f76cf95](f76cf95)) * styling ([553d512](553d512)) * update feature info to changes in react-geo ([35e8ab1](35e8ab1)) * white space ([080d582](080d582))
|
🎉 This PR is included in version 9.0.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
## [9.0.0](v8.11.1...v9.0.0) (2025-01-24) ### ⚠ BREAKING CHANGES * updates several major dependencies The following major dependencies have been updated - @terrestris/react-geo from version 23 to 25 - antd from 4 to 5 - react from version 17 to 18 - ol from version 7 to 10 - geostyler from 12 to 15 In addition webpack has been replaced by rspack. ### Dependencies * add a watch:buildto npm script entry ([18d5500](18d5500)) * ignore test-results in subpaths ([6eb402c](6eb402c)) * latest updates especially shogun-util and module federation ([46a950a](46a950a)) * merge branch 'next' into reloadFeatureFix ([810521e](810521e)) * **release:** 9.0.0-next.1 [skip ci] ([ec4134d](ec4134d)) * **release:** 9.0.0-next.2 [skip ci] ([d75d3d4](d75d3d4)), closes [#1762](#1762) * **release:** 9.0.0-next.3 [skip ci] ([5814db4](5814db4)) * **release:** 9.0.0-next.4 [skip ci] ([ce722d3](ce722d3)), closes [#1785](#1785) * **release:** 9.0.0-next.5 [skip ci] ([aa8af34](aa8af34)), closes [#1784](#1784) * **release:** 9.0.0-next.6 [skip ci] ([f44f9f3](f44f9f3)), closes [#1791](#1791) * remove non-working update-coverage workflow ([18956c6](18956c6)) * resolve merge conflicts ([e2e534d](e2e534d)) * resolve merge conflicts for merge into main ([91e9bc2](91e9bc2)) * try to fix coverage pipeline ([6cc0789](6cc0789)) * update dependencies ([7f91b84](7f91b84)) * update dependencies ([74460e9](74460e9)) * update dependencies ([e7fc751](e7fc751)) * update react-geo ([c278008](c278008)) ### Changes in configuration * define MULTI_LINES_TEXT ([f5ba097](f5ba097)) * ensure proper formatting ([8b89ca4](8b89ca4)) * fix end of file ([07e397f](07e397f)) * fix multiline handling ([d6dc266](d6dc266)) * properly escape echo command ([4ef7c94](4ef7c94)) * store and pass multiple-files-input correctly ([9a7cb97](9a7cb97)) ### Features * add XYZ and Stamen/Stadia serializers ([a0141cf](a0141cf)) * adds a configuration in the ToolConfig in order to customise display of layer-icons per app ([2f6538f](2f6538f)) * adds icon to indicate searchable, hoverable and/or editable layer ([25ef26a](25ef26a)) * adds Map Toolbar to the gis-client ([#1784](#1784)) ([6159ce8](6159ce8)) * adds reroute link from error page to login ([133c46c](133c46c)) * adds tooltips to layertree icons ([#1785](#1785)) ([05cf7ea](05cf7ea)) * include wfs search and refactor MultiSearch ([ada52b2](ada52b2)) * init ImportDataModal (and fix minor styling issues) ([08b1016](08b1016)) * introduces the new api endpoint applicationName ([#1791](#1791)) ([3d07d57](3d07d57)) * parse map interactions ([4525420](4525420)) * remove static loading text, add loading indicator and minor css cleanup ([92b0ec7](92b0ec7)) * update all dependencies to their latest versions ([3cfe3b3](3cfe3b3)) * update react-geo ([d51a10b](d51a10b)) ### Bugfixes * add layer to target group before adding it to the map ([4279c64](4279c64)) * add missing fields due to dependency update ([d623c5a](d623c5a)) * add missing keys in list ([9719761](9719761)) * check condition for icon display and styling ([bc33a7e](bc33a7e)) * condition checks and css ([87a1114](87a1114)) * coverage comment ([f43c290](f43c290)) * coverage comment (use printf) ([3c0cab7](3c0cab7)) * create deep clone from state value ([66dcc10](66dcc10)) * cursor jumps on keystroke ([691fe6f](691fe6f)) * drag and drop in nodeTitleRenderer ([a9264f2](a9264f2)) * fix client with terrestris dependencies update ([984dc23](984dc23)) * geometry edit tools and styling ([#1762](#1762)) ([1b6b833](1b6b833)) * layertree checkbox css ([c008409](c008409)) * layout and styling ([b8ee0df](b8ee0df)) * layout fixes ([3312620](3312620)) * make gfi edit button work in all scenarios ([96560c6](96560c6)) * make metadata configurable ([e8b5d3a](e8b5d3a)) * padding and extend link to the text ([038f251](038f251)) * padding in header ([3ed6ee5](3ed6ee5)) * prevent unnecessary rerenders of the Legend ([8219f57](8219f57)) * reactivate drill down feature info requests ([0058b88](0058b88)) * readd support for a custom favicon path ([7bd4bf4](7bd4bf4)) * reloadFeature ([703b34f](703b34f)) * remove empty element and add check ([a06b8ee](a06b8ee)) * restore the initial value ([a73e05b](a73e05b)) * rewording of translation text ([f76cf95](f76cf95)) * set correct translation key ([f06f46b](f06f46b)) * show legend for WMS layers only ([26dc9ee](26dc9ee)) * styling ([553d512](553d512)) * update feature info to changes in react-geo ([35e8ab1](35e8ab1)) * white space ([080d582](080d582))
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets geometry edit tools as inactive until activated by the users and applies styling fixes.