Testsetup #1029
Merged
Testsetup #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasLohoff
reviewed
Jul 25, 2023
src/e2e-tests/test-results/auth.setup.ts-authenticate-as-admin-setup-retry1/trace.zip
Outdated
Show resolved
Hide resolved
LukasLohoff
approved these changes
Jul 25, 2023
|
Thank you very much for the review @LukasLohoff ! |
dnlkoch
reviewed
Jul 25, 2023
Comment on lines
+8
to
+11
| process.env.ID; | ||
| process.env.HOST; | ||
| process.env.ADMIN_LOGIN; | ||
| process.env.ADMIN_PASSWORD; |
There was a problem hiding this comment.
Is this really needed? IMHO this makes no sense at all?
| @@ -17,29 +18,30 @@ export default defineConfig({ | |||
| open: 'never' | |||
| }]], | |||
| use: { | |||
| baseURL: process.env.HOST, | |||
| // das mal ausprobieren: | |||
There was a problem hiding this comment.
This comment can be removed I assume?
| import { test } from '@playwright/test'; | ||
|
|
||
| import { annotations } from '@terrestris/shogun-e2e-tests/dist/shogun-gis-client/toolbox/annotation'; | ||
| // import {header} from './header' |
| + 'code&scope=openid&nonce=6cd0da9a-b45c-4a9e-931d-99b6725a148e'); | ||
| await page.goto(`https://${process.env.HOST}/auth/realms/SHOGun` | ||
| + '/protocol/openid-connect/auth?client_id=shogun-client' | ||
| + `&redirect_uri=https%3A%2F%2F${process.env.HOST}%2Fclient%2F%3FapplicationId%3D21&state=9a983abe-3b0c-` |
There was a problem hiding this comment.
There are some hardcoded parameters, e.g. applicationId. Should we make them configurable?
| storageState: 'playwright/.auth/admin.json' | ||
| }); | ||
|
|
||
| test('test', async ({ |
There was a problem hiding this comment.
We should apply some useful names to the test (here and in all others).
| ] | ||
| "./src", | ||
| "e2e-tests/annotation.spec.ts", | ||
| "node_modules/@terrestris/shogun-e2e-tests/e2e-tests/shogun-gis-client/header/header", |
| "./src", | ||
| "e2e-tests/annotation.spec.ts", | ||
| "node_modules/@terrestris/shogun-e2e-tests/e2e-tests/shogun-gis-client/header/header", | ||
| "e2e-tests/annotation.spec.ts" |
There was a problem hiding this comment.
Duplicate entry. (Is this needed anyway?)
|
🎉 This PR is included in version 6.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the playwright config and adds aria-label as selectors.