Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct variable name for column definitions in checkbox selecti… #4056

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

mholthausen
Copy link
Member

Description

This PR fixes a minor issue where the variable name used to check for the presence of checkboxSelection in column definitions was incorrect. The variable colDefs was renamed to columnDefs as colDefs was used before it was initialized.

@terrestris/devs please review

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm run check locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@mholthausen mholthausen merged commit 90c5055 into main Oct 14, 2024
2 checks passed
@dnlkoch
Copy link
Member

dnlkoch commented Oct 14, 2024

🎉 This PR is included in version 25.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants