Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gamescope for older GPUs #1930

Merged
merged 14 commits into from
Aug 25, 2024
Merged

fix gamescope for older GPUs #1930

merged 14 commits into from
Aug 25, 2024

Conversation

korewaChino
Copy link
Contributor

@korewaChino korewaChino commented Aug 15, 2024

This PR patches the terra-gamescope package so that by default the SDL backend will be selected regardless of Wayland display support or not, requiring users to explicitly set --backend=wayland if they want to use the new Wayland backend for Gamescope, at the detriment of newer GPUs that support the Vulkan DRM modifiers feature.

Should work regardless on those aforementioned GPUs however.

Patch to work around ValveSoftware/gamescope#1218 on older GPUs.

If this patch works we may be able to simply obsolete gamescope-legacy

@korewaChino
Copy link
Contributor Author

Just tested this, turns out dedicated DRM sessions are still broken without legacy. Time for a better approach

@korewaChino
Copy link
Contributor Author

korewaChino commented Aug 15, 2024

Oddly enough, while this patch fixes nested sessions, turns out even without this patch Wayland and SDL backends work pretty much fine on my RX580?????????? And turns out the only problematic part here is the DRM backend, which seems to cause issues

@korewaChino korewaChino changed the title gamescope: make the SDL backend the default backend for all builds gamescope: make the SDL backend the default backend for nested sessions Aug 15, 2024
@korewaChino korewaChino changed the title gamescope: make the SDL backend the default backend for nested sessions fix gamescope for older GPUs Aug 15, 2024
@korewaChino
Copy link
Contributor Author

Currently considering obsoleting gamescope-legacy with a wrapper script that just runs gamescope with the SDL backend

@korewaChino korewaChino linked an issue Aug 20, 2024 that may be closed by this pull request
@korewaChino korewaChino marked this pull request as ready for review August 20, 2024 11:30
@madonuko madonuko merged commit e334d5d into frawhide Aug 25, 2024
4 checks passed
@madonuko madonuko deleted the pr/gamescope-sdl branch August 25, 2024 09:42
raboneko pushed a commit that referenced this pull request Aug 25, 2024
* gamescope: make the SDL backend the default backend for all builds

* add back funny patches

* Obsolete gamescope-legacy with wrapper script, fix multiarch subpackage

* fix dependency issue

* terra downstream script patches

* add the ctrl patch properly

* revert

* update to 3.15.0

* simplify wrapper script

* handle calling gamescope-legacy from non-gamescope session

* Use my PR patch for gamescope fallback

* format patch from github

* update patch

---------

Signed-off-by: Cappy Ishihara <[email protected]>
(cherry picked from commit e334d5d)
raboneko pushed a commit that referenced this pull request Aug 25, 2024
* gamescope: make the SDL backend the default backend for all builds

* add back funny patches

* Obsolete gamescope-legacy with wrapper script, fix multiarch subpackage

* fix dependency issue

* terra downstream script patches

* add the ctrl patch properly

* revert

* update to 3.15.0

* simplify wrapper script

* handle calling gamescope-legacy from non-gamescope session

* Use my PR patch for gamescope fallback

* format patch from github

* update patch

---------

Signed-off-by: Cappy Ishihara <[email protected]>
(cherry picked from commit e334d5d)
raboneko pushed a commit that referenced this pull request Aug 25, 2024
* gamescope: make the SDL backend the default backend for all builds

* add back funny patches

* Obsolete gamescope-legacy with wrapper script, fix multiarch subpackage

* fix dependency issue

* terra downstream script patches

* add the ctrl patch properly

* revert

* update to 3.15.0

* simplify wrapper script

* handle calling gamescope-legacy from non-gamescope session

* Use my PR patch for gamescope fallback

* format patch from github

* update patch

---------

Signed-off-by: Cappy Ishihara <[email protected]>
(cherry picked from commit e334d5d)
raboneko pushed a commit that referenced this pull request Aug 25, 2024
* gamescope: make the SDL backend the default backend for all builds

* add back funny patches

* Obsolete gamescope-legacy with wrapper script, fix multiarch subpackage

* fix dependency issue

* terra downstream script patches

* add the ctrl patch properly

* revert

* update to 3.15.0

* simplify wrapper script

* handle calling gamescope-legacy from non-gamescope session

* Use my PR patch for gamescope fallback

* format patch from github

* update patch

---------

Signed-off-by: Cappy Ishihara <[email protected]>
(cherry picked from commit e334d5d)
raboneko pushed a commit that referenced this pull request Aug 25, 2024
* gamescope: make the SDL backend the default backend for all builds

* add back funny patches

* Obsolete gamescope-legacy with wrapper script, fix multiarch subpackage

* fix dependency issue

* terra downstream script patches

* add the ctrl patch properly

* revert

* update to 3.15.0

* simplify wrapper script

* handle calling gamescope-legacy from non-gamescope session

* Use my PR patch for gamescope fallback

* format patch from github

* update patch

---------

Signed-off-by: Cappy Ishihara <[email protected]>
(cherry picked from commit e334d5d)
@raboneko
Copy link
Member

💔 Some backports could not be created

Status Branch Result
f39 An unhandled error occurred. Please see the logs for details
f40
f41 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 1930

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@raboneko
Copy link
Member

💔 Some backports could not be created

Status Branch Result
f39
f40
f41 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 1930

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

raboneko pushed a commit that referenced this pull request Aug 25, 2024
* gamescope: make the SDL backend the default backend for all builds

* add back funny patches

* Obsolete gamescope-legacy with wrapper script, fix multiarch subpackage

* fix dependency issue

* terra downstream script patches

* add the ctrl patch properly

* revert

* update to 3.15.0

* simplify wrapper script

* handle calling gamescope-legacy from non-gamescope session

* Use my PR patch for gamescope fallback

* format patch from github

* update patch

---------

Signed-off-by: Cappy Ishihara <[email protected]>
(cherry picked from commit e334d5d)
@raboneko
Copy link
Member

💔 Some backports could not be created

Status Branch Result
f39
f40 An unhandled error occurred. Please see the logs for details
f41

Manual backport

To create the backport manually run:

backport --pr 1930

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

raboneko pushed a commit that referenced this pull request Aug 25, 2024
* gamescope: make the SDL backend the default backend for all builds

* add back funny patches

* Obsolete gamescope-legacy with wrapper script, fix multiarch subpackage

* fix dependency issue

* terra downstream script patches

* add the ctrl patch properly

* revert

* update to 3.15.0

* simplify wrapper script

* handle calling gamescope-legacy from non-gamescope session

* Use my PR patch for gamescope fallback

* format patch from github

* update patch

---------

Signed-off-by: Cappy Ishihara <[email protected]>
(cherry picked from commit e334d5d)
raboneko pushed a commit that referenced this pull request Aug 25, 2024
* gamescope: make the SDL backend the default backend for all builds

* add back funny patches

* Obsolete gamescope-legacy with wrapper script, fix multiarch subpackage

* fix dependency issue

* terra downstream script patches

* add the ctrl patch properly

* revert

* update to 3.15.0

* simplify wrapper script

* handle calling gamescope-legacy from non-gamescope session

* Use my PR patch for gamescope fallback

* format patch from github

* update patch

---------

Signed-off-by: Cappy Ishihara <[email protected]>
(cherry picked from commit e334d5d)
@raboneko
Copy link
Member

💚 All backports created successfully

Status Branch Result
f39
f40
f41

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

madonuko pushed a commit that referenced this pull request Aug 26, 2024
* gamescope: make the SDL backend the default backend for all builds

* add back funny patches

* Obsolete gamescope-legacy with wrapper script, fix multiarch subpackage

* fix dependency issue

* terra downstream script patches

* add the ctrl patch properly

* revert

* update to 3.15.0

* simplify wrapper script

* handle calling gamescope-legacy from non-gamescope session

* Use my PR patch for gamescope fallback

* format patch from github

* update patch

---------

Signed-off-by: Cappy Ishihara <[email protected]>
(cherry picked from commit e334d5d)

Co-authored-by: Cappy Ishihara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] terra-gamescope crashes due to DMABUF bug
3 participants