Reusable importer steps #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LayerImport Dialog can differ with different geonode instances, this adds the ability to specify what is displayed in the importer window There are a few preconfigured elements, that can be turned on/off for example the layerName and permssion handling. The config will be set via reduy and read from there eventually. As well as the saving for all the fields in the other section
used for example for selecting a time window, start and end time using the available fields from the layer/api generate the list of keys for the layer and display them in the select field needed to include the tap-event plugin, otherwise the select fields would not have worked
use a service to generatwe the necessary configuration files for the LayerImport component add tests for service and the component make sure, that clicking import will call the import module
use steps and add defaults by design a step can have multiple substeps that are displayed in the same window
define your importer steps via vanilla js and convert the values put in by the users to json for the api to consume define your fields via json to let material-ui handle the display it is an reusable format which should be easy to implement inspiration from Mike Bostock (creator of d3)
add way to generate the config from the new configs and generate the steps necessarx pout of a single string or function array
convert the text/function config to steps to be used for material-ui/react add new component step to handle promises in the values for select fields
covergae html reporter now works again adding summarx reporter to include in the console
add more tests and remove old code
add more tests to increase test coverage
use new components in layerImport
Add documentation how to customize the LayerImport Add a new default for the customization, permissions, to show more ways to customize the layerImport
for permissions we need to select multiple users this adds the ability to have a select field which allows to select multiple users
it is not a configuration but a customization of the layer import move tests into separate files instead of one big file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Configuration
The importer wizard is easily customizable. You can specify the order and type of steps to be displayed in the wizard.
Right now we have a few limitations. Form types is limited to textfields and select fields. This will probably change in the future when more requests come in.
But a lot can be accomplished from these two types.