Remove easy handle before destruction

terrakuh · May 8, 2022 · 89e279c · 89e279c
1 parent 246d112
commit 89e279c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 # Change Log
 
-## [Unreleased]
+## [v0.3.1]
+### Fixed
+- Remove easy handle before destruction
 
 ## [v0.3] - 2022-04-25
 ### Added
@@ -24,6 +26,7 @@
 ### Fixed
 - Cookie share support
 
-[Unreleased]: https://github.com/terrakuh/curlio/compare/v0.3..dev
+[Unreleased]: https://github.com/terrakuh/curlio/compare/v0.3.1..dev
+[v0.3.1]: https://github.com/terrakuh/curlio/compare/v0.3..v0.3.1
 [v0.3]: https://github.com/terrakuh/curlio/compare/v0.2..v0.3
 [v0.2]: https://github.com/terrakuh/curlio/compare/v0.1..v0.2
diff --git a/curlio/session.hpp b/curlio/session.hpp
@@ -129,11 +129,11 @@ inline void Session::_clean_finished() noexcept
 	while ((message = curl_multi_info_read(_multi_handle, &left))) {
 		if (message->msg == CURLMSG_DONE) {
 			detail::Shared_data* data = nullptr;
+			curl_multi_remove_handle(_multi_handle, message->easy_handle);
 			if (curl_easy_getinfo(message->easy_handle, CURLINFO_PRIVATE, &data) == CURLE_OK && data != nullptr) {
 				CURLIO_DEBUG("Request " << data << " is done");
 				_active_requests.erase(data);
 			}
-			curl_multi_remove_handle(_multi_handle, message->easy_handle);
 		}
 	}
 }