Add support for tflint-ignore-file annotations in JSON #2230
+220
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isobit
force-pushed
the
2025-02-09/ignore-file-annotation-json
branch
4 times, most recently
from
b5d701c to
b99c64d
Compare
wata727
reviewed
Feb 10, 2025
isobit
force-pushed
the
2025-02-09/ignore-file-annotation-json
branch
from
b99c64d to
7dab624
Compare
isobit
force-pushed
the
2025-02-09/ignore-file-annotation-json
branch
2 times, most recently
from
e171cc2 to
dfdfd18
Compare
bendrucker
reviewed
Feb 10, 2025
isobit
force-pushed
the
2025-02-09/ignore-file-annotation-json
branch
2 times, most recently
from
5aa0b5f to
8b15cf7
Compare
isobit
force-pushed
the
2025-02-09/ignore-file-annotation-json
branch
2 times, most recently
from
942c6fd to
cf69671
Compare
isobit
force-pushed
the
2025-02-09/ignore-file-annotation-json
branch
from
cf69671 to
bb1bf7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I'm generating
.tf.jsonfiles for a bunch of different root modules; these.tf.jsonfiles define several locals for convenience, which may or may not be used by the root modules they're placed in. I wanted to be able to ignore theterraform_unused_declarationsrule without disabling it globally, but I realized that there wasn't a way to do this since the annotation system didn't support JSON files at all. This change adds limited support fortflint-ignore-fileannotations in a top-level comment property.