Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added kibana dashboard #309

Merged
merged 27 commits into from
Nov 7, 2024
Merged

feat: added kibana dashboard #309

merged 27 commits into from
Nov 7, 2024

Conversation

Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Oct 5, 2024 •
edited
Loading

Description

  • Added kibana dashboard to ES-DA.
    Git Issue
  • Also commented out 2 resource blocks elasticsearch_index and elasticsearch_cluster_settings in basic example which was causing the test to fail.
    Git Issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added kibana dashboard to ES-DA.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Ak-sky Ak-sky changed the title [DONOTMERGE]feat: added kibana dashboard feat: added kibana dashboard Oct 9, 2024
@Ak-sky Ak-sky marked this pull request as ready for review October 9, 2024 03:53
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 9, 2024

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 9, 2024

/run pipeline

vburckhardt
vburckhardt reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments, I think we should also give a general toggle as an input variable to allow to deploy or not kibana. We should also clearly highlight that the kibana image is not certified in any way by IBM, and coming from the official registry.

solutions/standard/main.tf Outdated Show resolved Hide resolved
solutions/standard/main.tf Outdated Show resolved Hide resolved
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 16, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 16, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 16, 2024

/run pipeline

vburckhardt
vburckhardt reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments, some additional minor items

solutions/standard/variables.tf Outdated Show resolved Hide resolved
solutions/standard/variables.tf Outdated Show resolved Hide resolved
solutions/standard/variables.tf Outdated Show resolved Hide resolved
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 17, 2024

/run pipeline

3 similar comments
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 17, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 17, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 17, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 17, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 22, 2024

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 23, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 23, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 23, 2024

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 23, 2024

/run pipeline

ocofaigh
ocofaigh requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ak-sky See https://github.com/terraform-ibm-modules/terraform-ibm-icd-elasticsearch/pull/309/files#r1814620706

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 5, 2024

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 6, 2024

/run pipeline

@Ak-sky Ak-sky requested a review from ocofaigh November 6, 2024 09:20
@vburckhardt
Copy link
Member

/run pipeline

vburckhardt
vburckhardt approved these changes Nov 6, 2024
View reviewed changes
solutions/standard/variables.tf Outdated Show resolved Hide resolved
@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 6, 2024

/run pipeline

2 similar comments
@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 7, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Nov 7, 2024

/run pipeline

@ocofaigh ocofaigh merged commit 8c3c2af into main Nov 7, 2024
2 checks passed
@ocofaigh ocofaigh deleted the es-kibana branch November 7, 2024 09:35
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

daniel-butler-irl pushed a commit that referenced this pull request Nov 18, 2024
@Ak-sky @daniel-butler-irl
feat: added support to the DA to deploy and manage a Kibana instance …
cc47167 
…in a code engine project. To enable, set `enable_kibana_dashboard` to `true` (#309)
@Ak-sky Ak-sky mentioned this pull request Dec 12, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@vburckhardt vburckhardt vburckhardt approved these changes

@daniel-butler-irl daniel-butler-irl Awaiting requested review from daniel-butler-irl daniel-butler-irl is a code owner

@shemau shemau Awaiting requested review from shemau shemau is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ak-sky @vburckhardt @terraform-ibm-modules-ops @ocofaigh