Skip to content

Commit

Permalink
Merge branch 'main' into ks-add-prefix-val
Browse files Browse the repository at this point in the history
  • Loading branch information
kierramarie authored Dec 9, 2024
2 parents 3ef8d23 + d6934c0 commit 4085847
Show file tree
Hide file tree
Showing 12 changed files with 56 additions and 62 deletions.
6 changes: 3 additions & 3 deletions cra-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ version: "v1"
CRA_TARGETS:
- CRA_TARGET: "solutions/instance" # Target directory for CRA scan. If not provided, the CRA Scan will not be run.
CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" # CRA Ignore file to use. If not provided, it checks the repo root directory for `cra-tf-validate-ignore-rules.json`
PROFILE_ID: "bfacb71d-4b84-41ac-9825-e8a3a3eb7405" # SCC profile ID (currently set to IBM Cloud Framework for Financial Services 1.6.0 profile).
PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile).
CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs.
TF_VAR_resource_group_name: "terraform-ibm-cos"
TF_VAR_provider_visibility: "public"
- CRA_TARGET: "solutions/secure-cross-regional-bucket" # Target directory for CRA scan. If not provided, the CRA Scan will not be run.
CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" # CRA Ignore file to use. If not provided, it checks the repo root directory for `cra-tf-validate-ignore-rules.json`
PROFILE_ID: "bfacb71d-4b84-41ac-9825-e8a3a3eb7405" # SCC profile ID (currently set to IBM Cloud Framework for Financial Services 1.6.0 profile).
PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile).
CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs.
TF_VAR_existing_kms_instance_crn: "crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9::"
TF_VAR_existing_cos_instance_id: "crn:v1:bluemix:public:cloud-object-storage:global:a/abac0df06b644a9cabc6e44f55b3880e:12345a67-12ab-1a23-abc1-1a2345abcde6::"
Expand All @@ -18,7 +18,7 @@ CRA_TARGETS:
TF_VAR_provider_visibility: "public"
- CRA_TARGET: "solutions/secure-regional-bucket" # Target directory for CRA scan. If not provided, the CRA Scan will not be run.
CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" # CRA Ignore file to use. If not provided, it checks the repo root directory for `cra-tf-validate-ignore-rules.json`
PROFILE_ID: "bfacb71d-4b84-41ac-9825-e8a3a3eb7405" # SCC profile ID (currently set to IBM Cloud Framework for Financial Services 1.6.0 profile).
PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile).
CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs.
TF_VAR_existing_kms_instance_crn: "crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9::"
TF_VAR_existing_cos_instance_id: "crn:v1:bluemix:public:cloud-object-storage:global:a/abac0df06b644a9cabc6e44f55b3880e:12345a67-12ab-1a23-abc1-1a2345abcde6::"
Expand Down
2 changes: 1 addition & 1 deletion examples/advanced/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ locals {

module "key_protect_all_inclusive" {
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
version = "4.16.11"
version = "4.17.1"
key_protect_instance_name = "${var.prefix}-kp"
resource_group_id = module.resource_group.resource_group_id
enable_metrics = false
Expand Down
6 changes: 3 additions & 3 deletions ibm_catalog.json
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
"profiles": [
{
"profile_name": "IBM Cloud Framework for Financial Services",
"profile_version": "1.6.0"
"profile_version": "1.7.0"
}
]
},
Expand Down Expand Up @@ -274,7 +274,7 @@
"profiles": [
{
"profile_name": "IBM Cloud Framework for Financial Services",
"profile_version": "1.6.0"
"profile_version": "1.7.0"
}
]
},
Expand Down Expand Up @@ -359,7 +359,7 @@
"profiles": [
{
"profile_name": "IBM Cloud Framework for Financial Services",
"profile_version": "1.6.0"
"profile_version": "1.7.0"
}
]
},
Expand Down
2 changes: 1 addition & 1 deletion solutions/instance/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ module "secrets_manager_service_credentials" {
count = length(local.service_credential_secrets) > 0 ? 1 : 0
depends_on = [time_sleep.wait_for_cos_authorization_policy]
source = "terraform-ibm-modules/secrets-manager/ibm//modules/secrets"
version = "1.18.14"
version = "1.19.3"
existing_sm_instance_guid = local.existing_secrets_manager_instance_guid
existing_sm_instance_region = local.existing_secrets_manager_instance_region
endpoint_type = var.existing_secrets_manager_endpoint_type
Expand Down
2 changes: 1 addition & 1 deletion solutions/instance/version.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ terraform {
required_providers {
ibm = {
source = "IBM-Cloud/ibm"
version = "1.71.2"
version = "1.71.3"
}
time = {
source = "hashicorp/time"
Expand Down
2 changes: 1 addition & 1 deletion solutions/secure-cross-regional-bucket/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ module "kms" {
}
count = var.existing_kms_key_crn != null ? 0 : 1 # no need to create any KMS resources if passing an existing key.
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
version = "4.16.11"
version = "4.17.1"
create_key_protect_instance = false
region = local.existing_kms_instance_region
existing_kms_instance_crn = var.existing_kms_instance_crn
Expand Down
2 changes: 1 addition & 1 deletion solutions/secure-cross-regional-bucket/version.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ terraform {
required_providers {
ibm = {
source = "IBM-Cloud/ibm"
version = "1.71.2"
version = "1.71.3"
}
time = {
source = "hashicorp/time"
Expand Down
2 changes: 1 addition & 1 deletion solutions/secure-regional-bucket/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ module "kms" {
}
count = var.existing_kms_key_crn != null ? 0 : 1 # no need to create any KMS resources if passing an existing key
source = "terraform-ibm-modules/kms-all-inclusive/ibm"
version = "4.16.11"
version = "4.17.1"
create_key_protect_instance = false
region = local.existing_kms_instance_region
existing_kms_instance_crn = var.existing_kms_instance_crn
Expand Down
2 changes: 1 addition & 1 deletion solutions/secure-regional-bucket/version.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ terraform {
required_providers {
ibm = {
source = "IBM-Cloud/ibm"
version = "1.71.2"
version = "1.71.3"
}
time = {
source = "hashicorp/time"
Expand Down
28 changes: 14 additions & 14 deletions tests/go.mod
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
module github.com/terraform-ibm-modules/terraform-ibm-cos

go 1.22.0
go 1.22.4

toolchain go1.23.3
toolchain go1.23.4

require (
github.com/IBM/ibm-cos-sdk-go v1.11.1
github.com/IBM/ibm-cos-sdk-go v1.12.0
github.com/gruntwork-io/terratest v0.47.2
github.com/stretchr/testify v1.9.0
github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper v1.41.4
github.com/stretchr/testify v1.10.0
github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper v1.42.4
)

require (
Expand All @@ -19,12 +19,12 @@ require (
cloud.google.com/go/storage v1.30.1 // indirect
dario.cat/mergo v1.0.0 // indirect
github.com/IBM-Cloud/bluemix-go v0.0.0-20240719075425-078fcb3a55be // indirect
github.com/IBM-Cloud/power-go-client v1.8.3 // indirect
github.com/IBM/cloud-databases-go-sdk v0.7.0 // indirect
github.com/IBM-Cloud/power-go-client v1.9.0 // indirect
github.com/IBM/cloud-databases-go-sdk v0.7.1 // indirect
github.com/IBM/go-sdk-core/v5 v5.18.1 // indirect
github.com/IBM/platform-services-go-sdk v0.71.0 // indirect
github.com/IBM/platform-services-go-sdk v0.72.0 // indirect
github.com/IBM/project-go-sdk v0.3.6 // indirect
github.com/IBM/schematics-go-sdk v0.3.0 // indirect
github.com/IBM/schematics-go-sdk v0.4.0 // indirect
github.com/IBM/vpc-go-sdk v1.0.2 // indirect
github.com/Microsoft/go-winio v0.6.1 // indirect
github.com/ProtonMail/go-crypto v1.0.0 // indirect
Expand Down Expand Up @@ -102,13 +102,13 @@ require (
go.opentelemetry.io/otel v1.16.0 // indirect
go.opentelemetry.io/otel/metric v1.16.0 // indirect
go.opentelemetry.io/otel/trace v1.16.0 // indirect
golang.org/x/crypto v0.29.0 // indirect
golang.org/x/crypto v0.30.0 // indirect
golang.org/x/mod v0.17.0 // indirect
golang.org/x/net v0.28.0 // indirect
golang.org/x/net v0.31.0 // indirect
golang.org/x/oauth2 v0.10.0 // indirect
golang.org/x/sync v0.9.0 // indirect
golang.org/x/sys v0.27.0 // indirect
golang.org/x/text v0.20.0 // indirect
golang.org/x/sync v0.10.0 // indirect
golang.org/x/sys v0.28.0 // indirect
golang.org/x/text v0.21.0 // indirect
golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d // indirect
golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
google.golang.org/api v0.127.0 // indirect
Expand Down
Loading

0 comments on commit 4085847

Please sign in to comment.