Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for deploying ocp in custom cloud endpoints #578

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Dec 24, 2024

Description

Add support to deploy to custom cloud endpoint.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 7, 2025

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 7, 2025

/run pipeline

variables.tf Outdated Show resolved Hide resolved
Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is the right way to address it, we should make the script to verify the value of an env var and to fall back to the default value if not set

More, we mustn't expose not public endpoints on public code/documentation

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 8, 2025

/run pipeline

@Aashiq-J Aashiq-J requested a review from vbontempi January 9, 2025 03:23
@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 9, 2025

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 9, 2025

/run pipeline

Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment, the changes are ok for me now

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 9, 2025

/run pipeline

Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to me

@Aashiq-J Aashiq-J merged commit 7a9f899 into main Jan 10, 2025
2 checks passed
@Aashiq-J Aashiq-J deleted the test-endpoint branch January 10, 2025 12:08
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants