Draft: Network dns refactory #1365
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renato-rudnicki
requested review from
eeaton,
rjerrems,
sleighton2022 and
a team
as code owners
renato-rudnicki
changed the title
daniel-cit
reviewed
Feb 17, 2025
daniel-cit
reviewed
Feb 17, 2025
| restricted_subnet_secondary_ranges = local.restricted_subnet_secondary_ranges | ||
| restricted_private_service_connect_ip = "10.17.0.8" | ||
| restricted_private_service_connect_ip = "10.17.0.7" |
daniel-cit
reviewed
Feb 17, 2025
daniel-cit
reviewed
Feb 17, 2025
daniel-cit
reviewed
Feb 17, 2025
daniel-cit
reviewed
Feb 17, 2025
| @@ -245,6 +246,10 @@ type NetSharedTfvars struct { | |||
| TargetNameServerAddresses []ServerAddress `hcl:"target_name_server_addresses"` | |||
| } | |||
|
|
|||
| type NetProductionTfvars struct { | |||
There was a problem hiding this comment.
this is a required field, not an optional field, what happens when you use the helper to deploy the hub and spoke alternative?
There was a problem hiding this comment.
I made a new deploy setting hub and spoke and everything works as exected. No errors. The NetProductionTfvars is being used on
https://github.com/renato-rudnicki/terraform-example-foundation/blob/5077d753bae1d283bc8904dfbba26d31f6a95a81/helpers/foundation-deployer/stages/apply.go#L298
// production
productionTfvars := NetProductionTfvars{
TargetNameServerAddresses: tfvars.TargetNameServerAddresses,
}
err = utils.WriteTfvars(filepath.Join(c.FoundationPath, step, "production.auto.tfvars"), productionTfvars)
if err != nil {
return err
}
It only create the production.auto.tfvars file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement a DNS hub for single forwarding between multiple hubs, enabling DNS communication between on-prem and a single GCP hub.